Turn on optimizations for unicode strings. #5457
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are the same as for strings, except indexing. Fixes #5454
cristianoc
commented
Jun 22, 2022
| @@ -268,6 +270,6 @@ let rev_toplevel_flatten block = | |||
|
|
|||
| let rec is_okay_to_duplicate (e : J.expression) = | |||
| match e.expression_desc with | |||
| | Var _ | Bool _ | Str _ | Number _ -> true | |||
| | Var _ | Bool _ | Str _ | Unicode _ | Number _ -> true | |||
There was a problem hiding this comment.
ok to duplicate unicode strings
| @@ -35,7 +35,7 @@ type t = J.expression | |||
| *) | |||
| let rec remove_pure_sub_exp (x : t) : t option = | |||
| match x.expression_desc with | |||
| | Var _ | Str _ | Number _ -> None (* Can be refined later *) | |||
| | Var _ | Str _ | Unicode _ | Number _ -> None (* Can be refined later *) | |||
There was a problem hiding this comment.
Looks like same behaviour as strings: both pure.
| @@ -173,7 +173,7 @@ module L = Literals | |||
| let typeof ?comment (e : t) : t = | |||
| match e.expression_desc with | |||
| | Number _ | Length _ -> str ?comment L.js_type_number | |||
| | Str _ -> str ?comment L.js_type_string | |||
| | Str _ | Unicode _ -> str ?comment L.js_type_string | |||
There was a problem hiding this comment.
Type of unicode is string.
| @@ -810,7 +812,8 @@ let uint32 ?comment n : J.expression = | |||
|
|
|||
| let string_comp (cmp : J.binop) ?comment (e0 : t) (e1 : t) = | |||
| match (e0.expression_desc, e1.expression_desc) with | |||
| | Str {txt=a0}, Str {txt=b0} -> ( | |||
| | Str {txt=a0}, Str {txt=b0} | |||
| | Unicode a0, Unicode b0 -> ( | |||
There was a problem hiding this comment.
Equality s1 == s2 should correspond to equal byte representation also in unicode.
| @@ -192,7 +192,7 @@ let subst_map (substitution : J.expression Hash_ident.t) = | |||
| let _, e, bindings = | |||
| Ext_list.fold_left ls (0, [], []) (fun (i, e, acc) x -> | |||
| match x.expression_desc with | |||
| | Var _ | Number _ | Str _ | J.Bool _ | Undefined -> | |||
| | Var _ | Number _ | Str _ | Unicode _ | J.Bool _ | Undefined -> | |||
There was a problem hiding this comment.
This is what enables inlining from the relevant issue linked to this PR.
| @@ -220,7 +220,7 @@ let record_scope_pass = | |||
| TODO: | |||
| *) | |||
| match x.expression_desc with | |||
| | Fun _ | Number _ | Str _ -> state | |||
| | Fun _ | Number _ | Str _ | Unicode _ -> state | |||
There was a problem hiding this comment.
Unicode strings are immutable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the same as for strings, except indexing.
Fixes #5454