Rescript format still removes the uncurried syntax from code even if `uncurried: false` in the bsconfig.

[JasoonS]

This came up when experimenting upgrading a library to v11-beta.2.

Here is the context: DZakh/sury#58 (comment)

[cristianoc]

Tried and it seems to work fine.
Need a minimal self-contained repro.

[JasoonS]

Hi Thanks for taking a look @cristianoc - I think there is a chance I just don't understand what the desired behavior.

It seems to turn all func(. into func( no matter which mode is enabled. Is this desired behaviour. Is the . syntax being deprecated?

Made a minimal reproduction here: https://github.com/JasoonS/uncurried-curried-rescript11-demo

• the main branch is v10
• Here I run npm format (which runs rescript format -all) on code which has uncurried: false: JasoonS/uncurried-curried-rescript11-demo@de5b358
• Here I run npm format on code which has uncurried: true: JasoonS/uncurried-curried-rescript11-demo@02c1eea (here the code formats to remove the dot, and it stops compiling)

[DZakh]

I've got it myself. It's not only rescript format but also format on save. Literally impossible to create an uncurried function in the uncurried: false mode.

[mxj4]

@cristianoc I found a different but similar issue when setting uncurried: false in bsconfig, might be related:

https://github.com/rescript-lang/rescript-compiler/blob/062c387f86020f72abee3b3aa2c2eaa0f3d67929/jscomp/syntax/src/res_multi_printer.ml#L57

I don't know how to write OCaml, but why we have negation over negation and raw string parsing rather than object deserialization? It feels like this is what it means:

If I have "uncurried": false in bsconfig.json, then

uncurried is true

and

false_ is true

then !uncurried && !false_ is false
then not (!uncurried && !false_) is true

then

https://github.com/rescript-lang/rescript-compiler/blob/062c387f86020f72abee3b3aa2c2eaa0f3d67929/jscomp/syntax/src/res_multi_printer.ml#L59

will set uncurried: true !

[cristianoc]

! mean dereference, rather than negation

[mxj4]

! mean dereference, rather than negation

😂 thx for explaining the basic syntax. Now I need to find out some other reasons why my uncurried: false does not work.

[mxj4]

@cristianoc someone in another repo mentioned

TheSpyder/rescript-mocha#4 (comment)

But it also means top level projects that depends on rescript-mocha would need to do the same in their bsconfig.json as well.

I'm not setting uncurried: false in my project, but setting it for a dependency rely on currying. Is that the reason why uncurried: false is not working for that dependency? Is it possible to not set this config in my project but use it in a dependency?

[DZakh]

Solved by #6353