Error in building ninja `/bin/sh: python: command not found`

[mununki]

When I tried to run npm install, I face the build error since the ninja is vendor instead of submodule.
python3 is installed on my machine but python@2. I tried to added an alias, but no gain.

OS: macOS on Apple silicon M1

> rescript@10.1.0-alpha.2 postinstall
> node scripts/install.js

building ninja
/bin/sh: python: command not found
node:child_process:903
    throw err;
    ^

Error: Command failed: python configure.py --bootstrap --verbose
    at checkExecSyncError (node:child_process:826:11)
    at Object.execSync (node:child_process:900:15)
    at Object.<anonymous> (/Users/woonki/Github/projects/rescript-compiler/scripts/buildNinjaBinary.js:18:17)
    at Module._compile (node:internal/modules/cjs/loader:1101:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1153:10)
    at Module.load (node:internal/modules/cjs/loader:981:32)
    at Function.Module._load (node:internal/modules/cjs/loader:822:12)
    at Module.require (node:internal/modules/cjs/loader:1005:19)
    at require (node:internal/modules/cjs/helpers:102:18)
    at build_ninja (/Users/woonki/Github/projects/rescript-compiler/scripts/install.js:67:7) {
  status: 127,
  signal: null,
  output: [ null, null, null ],
  pid: 7079,
  stdout: null,
  stderr: null
}
npm ERR! code 1
npm ERR! path /Users/woonki/Github/projects/rescript-compiler
npm ERR! command failed
npm ERR! command sh -c node scripts/install.js

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/woonki/.npm/_logs/2022-09-19T13_49_03_621Z-debug.log

[mununki]

I fixed it changing python -> python3.
https://github.com/rescript-lang/rescript-compiler/blob/88488a0bda6716af68beb44c0ec3dc960c4a9356/scripts/buildNinjaBinary.js#L9

[cristianoc]

I fixed it changing python -> python3.

https://github.com/rescript-lang/rescript-compiler/blob/88488a0bda6716af68beb44c0ec3dc960c4a9356/scripts/buildNinjaBinary.js#L9

Feel free to open a PR
CC @cknitt

[mununki]

I don't have much knowledge about ninja. Not sure building with python3 would be fine.
AFAIK, macOS doesn't ship the python@2 anymore. So, I'm trying to install python2 through pyenv first, then try to build ninja with it.

[cristianoc]

I don't think it needs pyrhon2

[mununki]

I don't think it needs pyrhon2

If so, I'll make a PR to change the build script with python3.