Track scope properly when inferring values #869
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zth
changed the title
cristianoc
approved these changes
Dec 18, 2023
|
|
||
| type t = item list | ||
|
|
||
| open SharedTypes.ScopeTypes |
There was a problem hiding this comment.
Ah in the pattern matching below.
There was a problem hiding this comment.
Yeah exactly, I opened it just to have it function as it did before.
Oh no idea lol. Probably. But at least not from this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an infinite loop bug that was cause by not tracking the scope properly as we infer values from unsaved content. All inference worked on the same, final scope, which led to infinite loops when adding a new binding to scope with a name that was already in scope.
Now, each value in scope tracks its own scope properly, and this fixes the bug.