Improve generation of function template variable names #754
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like CI is red. |
|
No idea why CI is red now, everything passes locally. Will try and figure out tomorrow. |
cristianoc
reviewed
Apr 4, 2023
cristianoc
approved these changes
Apr 4, 2023
zth
force-pushed
the
poc-template-variable-names
branch
from
c684fbb to
31d576e
Compare
|
@cristianoc I removed the custom attribute stuff, and just went with improving the template variable names for now. |
cristianoc
approved these changes
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're able to generate function template/snippets for callbacks since a while back. But, given that the type information has no name for unlabelled arguments, we've been forced to call most variables in the generated template
v(with a few notable exceptions that we've special cased).This PR improves how we infer template variable names by looking at the type path. For example, the type
Environment.twould be calledenvironmentin templates, whereasEnvironment.envConfigwould be calledenvConfig.This can help the DX quite a lot, because we can capture some of the variable name intent, at least for more complex types.
Before:
After:
I think this will be quite useful, but interested in hearing more thoughts.