Skip to content

Open Pervasives.JsxModules by default. #752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 22, 2023
Merged

Open Pervasives.JsxModules by default. #752

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion analysis/src/Packages.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ let newBsPackage ~rootPath =
| None -> []
in
let opens =
opens_from_namespace
["Pervasives"; "JsxModules"] :: opens_from_namespace
|> List.rev_append opens_from_bsc_flags
|> List.map (fun path -> path @ ["place holder"])
in
Expand Down
3 changes: 3 additions & 0 deletions analysis/tests/src/expected/BrokenParserCases.res.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,15 @@ Complete src/BrokenParserCases.res 2:24
posCursor:[2:24] posNoWhite:[2:23] Found expr:[2:11->2:30]
Pexp_apply ...[2:11->2:17] (~isOff2:19->2:24=...[2:27->2:29])
Completable: CnamedArg(Value[someFn], isOff, [isOff])
Package opens Pervasives.JsxModules.place holder
ContextPath Value[someFn]
Path someFn
[]

Complete src/BrokenParserCases.res 6:17
posCursor:[6:17] posNoWhite:[6:16] Found pattern:[6:16->6:19]
Completable: Cpattern Value[s]=t
Package opens Pervasives.JsxModules.place holder
ContextPath Value[s]
Path s
[]
Expand All @@ -18,6 +20,7 @@ posCursor:[10:29] posNoWhite:[10:27] Found pattern:[10:24->10:39]
posCursor:[10:29] posNoWhite:[10:27] Found pattern:[10:24->10:28]
Ppat_construct None:[10:24->10:28]
Completable: Cpath Value[None]
Package opens Pervasives.JsxModules.place holder
ContextPath Value[None]
Path None
[]
Expand Down
1 change: 1 addition & 0 deletions analysis/tests/src/expected/CompletePrioritize1.res.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
Complete src/CompletePrioritize1.res 5:6
posCursor:[5:6] posNoWhite:[5:5] Found expr:[5:3->0:-1]
Completable: Cpath Value[a]->
Package opens Pervasives.JsxModules.place holder
ContextPath Value[a]->
ContextPath Value[a]
Path a
Expand Down
2 changes: 2 additions & 0 deletions analysis/tests/src/expected/CompletePrioritize2.res.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
Complete src/CompletePrioritize2.res 9:7
posCursor:[9:7] posNoWhite:[9:6] Found expr:[9:3->0:-1]
Completable: Cpath Value[ax]->
Package opens Pervasives.JsxModules.place holder
ContextPath Value[ax]->
ContextPath Value[ax]
Path ax
Expand All @@ -20,6 +21,7 @@ Complete src/CompletePrioritize2.res 12:5
posCursor:[12:5] posNoWhite:[12:4] Found expr:[12:3->12:5]
Pexp_ident ax:[12:3->12:5]
Completable: Cpath Value[ax]
Package opens Pervasives.JsxModules.place holder
ContextPath Value[ax]
Path ax
[{
Expand Down
Loading