Publish LSP to npm

[aspeddro]

• Publish a binary to npm as rescriptls. Support two channels stdio and node-ipc
• VSCode client keeps using node-ipc channel

Related #354

[zth]

Great stuff!

One thing I'd like to mull over a bit before going this route is that there might be a separate case for publishing just the analysis binary to npm, by itself. That would be because the analysis binary might in the future contain more general tooling, not just stuff for powering the LSP. Doc extraction is one example where it's possible that's the easiest way of distributing it.

This package will have the analysis bin too of course. So maybe there's a way to name this (and expose the analysis bin separately) so that they can be exposed via the same package, without it being fantastically confusing.. Let me think a bit. Any feedback welcome.

[cristianoc]

Perhaps only expose the part of the analysis binary which is for public consumption. Without even leaking the existence of the binary (helps keeping freedom to move stuff between binary and ts).

[aspeddro]

If I understand correctly, as reported by users the main problem is that we don't publish an LSP like OCaml does to facilitate the setup in several editors. Just publishing the analysis binary does not resolve the reported issue.

yes accessing lsp server and related binaries each time when changing machine that doesn't have it mean setting up $PATH or changing editor configuration file (in this case Helix) over again. npm package definitely help.
Comment

One idea is to do what rust-analyzer does. We publish a single binary with subcommands.

• rescript-toolchain lsp [args] - Start LSP
• rescript-toolchain analysis [args] - Call OCaml analysis binary commands

[aspeddro]

Ready for review.

[aspeddro]

The first version should be 0.1.0 or 1.20?

[zth]

Awesome! I think 1.20.0 for the version is right, it's nice to have the same as the actual extension.

Fantastic to get this out.