Redo pr 649

CHANGELOG.md

@@ -41,6 +41,8 @@
 
 - Fix issue with references to elements defined in an interface file https://github.com/rescript-lang/rescript-vscode/pull/646
 
+- Fix issue with references from implementation files which also happen to have interface files https://github.com/rescript-lang/rescript-vscode/issues/645
+
 ## v1.8.2
 
 #### :rocket: New Feature

analysis/src/Cmt.ml

@@ -24,12 +24,12 @@ let fullFromUri ~uri =
       prerr_endline ("can't find module " ^ moduleName);
       None)
 
-let fullFromModule ~package ~moduleName =
+let fullsFromModule ~package ~moduleName =
   if Hashtbl.mem package.pathsForModule moduleName then
     let paths = Hashtbl.find package.pathsForModule moduleName in
-    let uri = getUri paths in
-    fullFromUri ~uri
-  else None
+    let uris = getUris paths in
+    uris |> List.filter_map (fun uri -> fullFromUri ~uri)
+  else []
 
 let loadFullCmtFromPath ~path =
   let uri = Uri.fromPath path in

analysis/src/References.ml

@@ -506,28 +506,24 @@ let forLocalStamp ~full:{file; extra; package} stamp (tip : Tip.t) =
                 package.projectFiles |> FileSet.elements
                 |> List.filter (fun name -> name <> file.moduleName)
                 |> List.map (fun moduleName ->
-                       match ProcessCmt.fileForModule ~package moduleName with
-                       | None -> []
-                       | Some file -> (
-                         match Cmt.fullFromModule ~package ~moduleName with
-                         | None -> []
-                         | Some {extra} -> (
-                           match
-                             Hashtbl.find_opt extra.externalReferences
-                               thisModuleName
-                           with
-                           | None -> []
-                           | Some refs ->
-                             let locs =
-                               refs
-                               |> Utils.filterMap (fun (p, t, locs) ->
-                                      if p = path && t = tip then Some locs
-                                      else None)
-                             in
-                             locs
-                             |> List.map (fun loc ->
-                                    {uri = file.uri; locOpt = Some loc}))))
-                |> List.concat
+                       Cmt.fullsFromModule ~package ~moduleName
+                       |> List.map (fun {file; extra} ->
+                              match
+                                Hashtbl.find_opt extra.externalReferences
+                                  thisModuleName
+                              with
+                              | None -> []
+                              | Some refs ->
+                                let locs =
+                                  refs
+                                  |> Utils.filterMap (fun (p, t, locs) ->
+                                         if p = path && t = tip then Some locs
+                                         else None)
+                                in
+                                locs
+                                |> List.map (fun loc ->
+                                       {uri = file.uri; locOpt = Some loc})))
+                |> List.concat |> List.concat
               in
               alternativeReferences @ externals)
           else (

analysis/src/SharedTypes.ml

@@ -295,6 +295,12 @@ let getUri p =
   | Namespace {cmt} -> Uri.fromPath cmt
   | IntfAndImpl {resi} -> Uri.fromPath resi
 
+let getUris p =
+  match p with
+  | Impl {res} -> [Uri.fromPath res]
+  | Namespace {cmt} -> [Uri.fromPath cmt]
+  | IntfAndImpl {res; resi} -> [Uri.fromPath res; Uri.fromPath resi]
+
 let getCmtPath ~uri p =
   match p with
   | Impl {cmt} -> cmt

analysis/tests/src/References.res

@@ -19,4 +19,7 @@ module M: {
 let bb = M.aa
 let cc = bb
 let dd = M.aa
-//          ^ref
+//          ^ref
+
+let _ = <ComponentInner/>
+//             ^ref

analysis/tests/src/expected/References.res.txt

@@ -21,3 +21,13 @@ References src/References.res 20:12
 {"uri": "References.res", "range": {"start": {"line": 20, "character": 11}, "end": {"line": 20, "character": 13}}}
 ]
 
+References src/References.res 23:15
+getLocItem #4: heuristic for </Comp> within fragments: take make as makeProps does not work
+the type is not great but jump to definition works
+[
+{"uri": "ReferencesInner.res", "range": {"start": {"line": 1, "character": 28}, "end": {"line": 1, "character": 32}}},
+{"uri": "References.res", "range": {"start": {"line": 23, "character": 19}, "end": {"line": 23, "character": 23}}},
+{"uri": "ComponentInner.res", "range": {"start": {"line": 1, "character": 4}, "end": {"line": 1, "character": 8}}},
+{"uri": "ComponentInner.resi", "range": {"start": {"line": 1, "character": 4}, "end": {"line": 1, "character": 8}}}
+]
+

analysis/tests/src/inner/ComponentInner.res

@@ -0,0 +1,2 @@
+@react.component
+let make = () => React.null

analysis/tests/src/inner/ComponentInner.resi

@@ -0,0 +1,2 @@
+@react.component
+let make: unit => React.element

analysis/tests/src/inner/ReferencesInner.res

@@ -0,0 +1,2 @@
+@react.component
+let make = () => <ComponentInner/>

analysis/tests/src/inner/ReferencesInner.resi

@@ -0,0 +1,2 @@
+@react.component
+let make: unit => React.element