Skip to content

Fix issue where module paths in -open in bsc-flags such as "-open Re… #608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 21, 2022
Merged

Fix issue where module paths in -open in bsc-flags such as "-open Re… #608

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ea21163
Fis issue where module paths in `-open` `bsc-flags` such as "-open Re…
cristianoc Oct 21, 2022
ac1b0d1
Update CHANGELOG.md
cristianoc Oct 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,10 @@

## master

#### :bug: Bug Fix

- Fix issue where module paths in `-open` in `bsc-flags` such as "-open ReScriptJs.Js" were not recognized https://github.com/rescript-lang/rescript-vscode/issues/607

## v1.8.1

#### :rocket: New Feature
Expand Down
4 changes: 3 additions & 1 deletion analysis/src/Packages.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,9 @@ let newBsPackage ~rootPath =
| Some s -> (
let parts = String.split_on_char ' ' s in
match parts with
| "-open" :: name :: _ -> name :: opens
| "-open" :: name :: _ ->
let names = name |> String.split_on_char '.' in
names @ opens
| _ -> opens))
[] l
| None -> []
Expand Down