Skip to content

Add example for dead code elimination for JSX v4. #593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 28, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion analysis/reanalyze/examples/deadcode/expected/deadcode.txt
Original file line number Diff line number Diff line change
Expand Up @@ -1101,6 +1101,9 @@
addRecordLabelDeclaration text ImportMyBanner.res:5:16 path:+ImportMyBanner.message
addValueReference ImportMyBanner.res:12:4 --> ImportMyBanner.res:7:0
Scanning JSResource.cmt Source:JSResource.res
Scanning JsxV4.cmt Source:JsxV4.res
addValueDeclaration +make JsxV4.res:4:23 path:+JsxV4.C
addValueReference JsxV4.res:4:36 --> React.res:3:0
Scanning LetPrivate.cmt Source:LetPrivate.res
addValueDeclaration +y LetPrivate.res:7:4 path:+LetPrivate
addValueDeclaration +x LetPrivate.res:3:6 path:+LetPrivate.local_1
Expand Down Expand Up @@ -1887,6 +1890,7 @@ File References
ImportJsValue.res -->>
ImportMyBanner.res -->>
JSResource.res -->>
JsxV4.res -->> React.res
LetPrivate.res -->>
ModuleAliases.res -->>
ModuleAliases2.res -->>
Expand Down Expand Up @@ -2121,6 +2125,7 @@ File References
Dead Value +ImportMyBanner.+make: 0 references () [0]
Live Value +ImportMyBanner.+make: 0 references () [0]
Dead RecordLabel +ImportMyBanner.message.text: 0 references () [0]
Dead Value +JsxV4.C.+make: 0 references () [0]
Live Value +LetPrivate.+y: 0 references () [0]
Live Value +LetPrivate.local_1.+x: 1 references (LetPrivate.res:7:4) [0]
Live Value +ModuleAliases.+testInner2: 0 references () [0]
Expand Down Expand Up @@ -3981,6 +3986,16 @@ File References
<-- line 12
@dead("make") let make = make

Warning Dead Module
File "JsxV4.res", line 3, characters 8-62
JsxV4.C is a dead module as all its items are dead.

Warning Dead Value
File "JsxV4.res", line 4, characters 20-47
C.make is never used
<-- line 4
@react.component @dead("C.make") let make = () => React.null

Warning Dead Module
File "ModuleAliases.res", line 2, characters 10-57
ModuleAliases.Outer.Inner is a dead module as all its items are dead.
Expand Down Expand Up @@ -4505,4 +4520,4 @@ File References
<-- line 96
type variant1Object = | @dead("variant1Object.R") R(payload)

Analysis reported 334 issues (Incorrect Dead Annotation:1, Warning Dead Exception:2, Warning Dead Module:25, Warning Dead Type:89, Warning Dead Value:199, Warning Dead Value With Side Effects:2, Warning Redundant Optional Argument:5, Warning Unused Argument:11)
Analysis reported 336 issues (Incorrect Dead Annotation:1, Warning Dead Exception:2, Warning Dead Module:26, Warning Dead Type:89, Warning Dead Value:200, Warning Dead Value With Side Effects:2, Warning Redundant Optional Argument:5, Warning Unused Argument:11)
18 changes: 18 additions & 0 deletions analysis/reanalyze/examples/deadcode/src/JsxV4.bs.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 7 additions & 0 deletions analysis/reanalyze/examples/deadcode/src/JsxV4.res
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
@@jsxConfig({version: 4})

module C = {
@react.component let make = () => React.null
}

let _ = <C />