Skip to content

add debug utilities #587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 19, 2022
Merged

add debug utilities #587

merged 1 commit into from
Sep 19, 2022

Conversation

zth
Copy link
Collaborator

@zth zth commented Sep 18, 2022

This adds some (hopefully) useful debug utilities from this branch https://github.com/rescript-lang/rescript-vscode/tree/type-based-autocomplete

Reason being that branch still requires quite a lot of additional work before being mergeable, but these things are immediately useful.

@zth zth requested a review from cristianoc September 18, 2022 18:04
Copy link
Collaborator

@cristianoc cristianoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great!

On the comment that this is incomplete: in what way is it incomplete.
If it's cases missing or something: does it print something saying "case X TODO" so it's clear it needs to be filled in? Or is it some other kind of incompleteness?

@zth
Copy link
Collaborator Author

zth commented Sep 19, 2022

Yes exactly, it's cases missing, and it does print that there's an unhandled case (and mostly even what that case is).

@zth zth merged commit 5e0e44e into master Sep 19, 2022
@zth zth deleted the debug-utils branch September 19, 2022 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants