fix watcher race condition #56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
on some sytems the compiler was not readable after chokidar called sendUpdateDiagnostics. Setting "awaitWriteFinish" as an option fixes the issue
marcoemrich
changed the title
|
Thanks! This heuristics is really unfortunate. And 500ms is a lot. I'd rather long poll than use a watcher in this case, as the watcher has other problems (e.g. not detecting the creation of the |
|
ups, no! I already updated to 1ms. Seems it didn't make it upstream. Sorry - I update the PR. |
|
Cool, thanks! Merging. Let's hope there's no report of new odd behaviors. Watchers are scary things we're thinking of removing one day... |
|
Thanks for Merging! Yes, watchers are really hard to use, every file system could behave differently. I'm just happy it works right now :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see issue #55
on some sytems the
.compiler.logwas not readable afterchokidar called sendUpdateDiagnostics. Setting
awaitWriteFinish as an option fixes the issue