Skip to content

prompt user to explicitly allow formatting using the built in formatter #558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 30, 2022

Conversation

zth
Copy link
Collaborator

@zth zth commented Aug 30, 2022

This adds a setting for explicitly allowing the use of the built in formatter when trying to format a ReScript file that's not strictly part of a ReScript project. Whenever a user tries to format a file where the ReScript compiler can't be found, the user will be prompted that explicit permissions are needed, together with a link to that specific setting.

image

image

image

Closes #556

@zth zth requested a review from cristianoc August 30, 2022 19:14
@zth zth requested a review from cristianoc August 30, 2022 19:38
@zth zth merged commit 1c07abf into master Aug 30, 2022
@zth zth deleted the prompt-to-allow-using-built-in-formatter branch August 30, 2022 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem with formatting with built-in compiler.
2 participants