Skip to content

Fix isNamespaced check when namespace is string #546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 5, 2022
Merged

Fix isNamespaced check when namespace is string #546

merged 1 commit into from
Aug 5, 2022

Conversation

fhammerschmidt
Copy link
Member

Apparently, Json.bool returns None when the value is there but not a boolean.

@cristianoc
Copy link
Collaborator

Good catch.

@cristianoc cristianoc merged commit 9d7573c into rescript-lang:master Aug 5, 2022
@fhammerschmidt fhammerschmidt deleted the fix-namespace-alias branch August 5, 2022 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fhammerschmidt @cristianoc