Skip to content

Fix commit SHA in artifact name for PR builds #505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 24, 2022
Merged

Fix commit SHA in artifact name for PR builds #505

merged 1 commit into from
Jul 24, 2022

Conversation

cknitt
Copy link
Member

@cknitt cknitt commented Jul 20, 2022 •
edited
Loading

This fixes the commit SHA used for the VSIX artifact name in PR builds.

Now it matches the last commit in the PR (9fe9e91 in this case).

@cknitt cknitt marked this pull request as ready for review July 20, 2022 18:59
@cknitt cknitt requested a review from zth July 20, 2022 19:10
zth
zth approved these changes Jul 24, 2022
View reviewed changes
Copy link
Collaborator

@zth zth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff, thank you!

@zth zth merged commit 35ac5f2 into rescript-lang:master Jul 24, 2022
@cknitt cknitt deleted the fix-commit-sha branch July 24, 2022 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zth zth zth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cknitt @zth