fix: don't show "start a build" if the file is in node_modules #472
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ah-yu
changed the title
cristianoc
approved these changes
Jun 29, 2022
server/src/server.ts
Outdated
| @@ -188,7 +189,7 @@ let openedFile = (fileUri: string, fileContent: string) => { | |||
| openFiles: new Set(), | |||
| filesWithDiagnostics: new Set(), | |||
| bsbWatcherByEditor: null, | |||
| hasPromptedToStartBuild: false, | |||
| hasPromptedToStartBuild: projectRootPath.includes("node_modules") ? "never" : false, | |||
There was a problem hiding this comment.
Is this just string search?
There was a problem hiding this comment.
Any risk one puts the file in this_is_not_node_modules_carrots or is that too pedantic?
There was a problem hiding this comment.
One could make it includes("/node_modules/") and we should be as safe as we can be.
There was a problem hiding this comment.
@zth but it will fail on windows
There was a problem hiding this comment.
Right. But looks like you accounted for that in your fix.
|
This is great. Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #471