Skip to content

Syntax highlighting: support more themes. #406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 6, 2022
Merged

Syntax highlighting: support more themes. #406

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b3c33b2
Syntax highlighting: support more themes.
cristianoc May 5, 2022
a456d02
Make "One Dark Pro" theme happy.
cristianoc May 5, 2022
ebbfae8
Un-recommend Mariana Pro].
cristianoc May 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ Our highlighting works well with most popular VSCode themes, such as:
- Monokai Dimmed
- Tomorrow Night Blue
- [One Dark Pro](https://marketplace.visualstudio.com/items?itemName=zhuangtongfa.Material-theme)
- [Mariana Pro](https://marketplace.visualstudio.com/items?itemName=rickynormandeau.mariana-pro)

The only 2 themes we don't (and can't) support, due to their lack of coloring, are:

Expand Down
2 changes: 1 addition & 1 deletion grammars/rescript.tmLanguage.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
"match": "\\b(false|true)\\b"
},
"RE_KEYWORD": {
"name": "keyword",
"name": "storage.type",
"match": "\\b(include|let|module|of|open|type)\\b"
},
"commentLine": {
Expand Down
3 changes: 2 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,8 @@
{
"scopes": {
"jsx-lowercase": ["entity.name.tag"],
"jsx-tag": ["punctuation.definition.tag"]
"jsx-tag": ["punctuation.definition.tag"],
"support-type-primitive": ["support.type.primitive"]
}
}
],
Expand Down
2 changes: 1 addition & 1 deletion server/src/server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -815,7 +815,7 @@ function onMessage(msg: m.Message) {
tokenTypes: [
"operator",
"variable",
"type",
"support-type-primitive",
"jsx-tag",
"class",
"enumMember",
Expand Down