Syntax highlighting broken in 1.19.6

[mxj4]

I installed pre-release version 1.19.6 and found the end of the %%raw() cannot be identified correctly, now everything starting from %%raw( share the same color:

This does not happen in 1.18.0:

[fhammerschmidt]

The problem here is that JS syntax highlighting encounters no end symbol like a newline or a ;.

But this can be easily fixed in the following ways:

1. Use regular strings:

%%raw("import './App.css'")

2. Terminate the embedded JS with a semicolon

%%raw(`import './App.css';`)

3. Or use multiple lines

%%raw(`
  import './App.css'
`)

TBH I did not really account for the single line syntax highlight when I implemented this feature, what should we do in that case? One workaround would be to just automatically format to one of the above suggestions, another one would be to only support JS syntax highlighting in multiline extension points (not sure if that is possible just with the tmlanguage grammar).

cc @zth @cristianoc

[zth]

Is the embedded string responsible for terminating? I'd expect the editor to highlight the embedded text up until some termination of the embedded string itself (`) in this case) but maybe that's not how it works?

[fhammerschmidt]

My textmate knowledge is not good enough, but I imagine the embedded JS syntax finds no stop condition, and `) is very valid JS.

Edit: Supporting only multiline is actually easy. Just need to add a \n to the begin and end fields. found another fix, see below

[fhammerschmidt]

Found a fix, I just added another single line pattern.