Formatting after editting is failed with v1.4.2 but ok with v1.4.1.

[Mng12345]

rescript[v9.1.4]
vscode extension[v.1.4.2]
system [windows x64]
Failed to format the code with vscode extension of version 1.4.2

[cristianoc]

More details: what's the behaviour on one example, and what's the expected behaviour?

[Mng12345]

[Mng12345]

This is the example repo
https://github.com/Mng12345/rescript_142_notformatted.git
rescript-vscode 1.4.2
The global settings.json

{
  "[rescript]": {
    "editor.defaultFormatter": "chenglou92.rescript-vscode",
  },
  "rescript": {
      "aliases": [
        "ReScript"
      ],
      "filenames": [],
      "extensions": [
        ".res",
        ".resi"
      ],
      "lineComments": [
        "//"
      ],
      "blockComments": [
        [
          "/*",
          "*/"
        ]
      ],
      "blockStrings": []
    },
}

[fhammerschmidt]

Your example works fine for me (on macOS).

Please continue only here with your findings and don't spam multiple forum posts.

As you mentioned in https://forum.rescript-lang.org/t/the-html-code-is-not-formatted-in-react-component-with-this-use-case/3585/: Yes, the path seems not to be the issue. I guess it even calls the formatter but fails somewhere.

Can you debug the formatCode function in utils.ts? Especially log out bscPath and the result in there. Then try formatting and have a look at the Debug Console of 'Attach to Server'.

Also the other null bug is probably because you don't have an analysis binary built? If you cannot build it, grab it from https://github.com/rescript-lang/rescript-vscode/releases/download/1.4.2/rescript-vscode-1.4.2.vsix, unzip it and copy the extension/server/analysis_binaries to your checked out rescript-vscode repo. Then it should not crash.

[Mng12345]

Your example works fine for me (on macOS).

Please continue only here with your findings and don't spam multiple forum posts.

As you mentioned in https://forum.rescript-lang.org/t/the-html-code-is-not-formatted-in-react-component-with-this-use-case/3585/: Yes, the path seems not to be the issue. I guess it even calls the formatter but fails somewhere.

Can you debug the formatCode function in utils.ts? Especially log out bscPath and the result in there.

Also the other null bug is probably because you don't have an analysis binary built? If you cannot build it, grab it from https://github.com/rescript-lang/rescript-vscode/releases/download/1.4.2/rescript-vscode-1.4.2.vsix, unzip it and copy the extension/server/analysis_binaries to your checked out rescript-vscode repo. Then it should not crash.

Thanks! i will try it now!

[Mng12345]

mnggiflab-download (26).webm
The call childProcess.execFileSync just fall into nothing.

[Mng12345]

Sorry for ignored the catch block, this is the error stack:

[Mng12345]

@fhammerschmidt I also execute the command in my project root path.

[Mng12345]

@fhammerschmidt, i tried bsc.cmd, the command worked well.


Probably something is wrong in the bsc

[fhammerschmidt]

Dumb question: What if you call bsc.cmddirectly in the execFileSync call?

EDIT: Ah you just tried, great!

[Mng12345]

After changing the bscBinName from bsc into bsc.cmd, the formatting function worked normally!
I wish someday i can build and run this project on windows, so i can make some PR directly. 😘

[fhammerschmidt]

I could make a fix soon, but I just wonder how this could ever work before on Windows. There is some special logic to handle the call of the watcher directly, but not the other executables. In my opinion, this logic should be reused for all executables in the node_modules/.bin folder. But we have to discuss it internally first.

[Mng12345]

Thanks, i will clone the project with the version of v1.4.1, and find why in tonight later.

[TheSpyder]

I just saw the forum post and was going to comment - but I'll do it here instead - when making "symlinks" on windows for the .bin folder, npm creates .cmd files. These operate the same from the command line, because on windows trying to run rescript will also look for rescript.exe and rescript.cmd, but that automatic searching doesn't work when spawning a new process. At that point the .cmd is required.

I just wonder how this could ever work before on Windows

I have no idea 🤷‍♂️ maybe an accident of how it was spawned before.

[fhammerschmidt]

@Mng12345 I may have fixed it already. Please try the VSIX from https://github.com/rescript-lang/rescript-vscode/actions/runs/2738948024 when the build finishes.