Trouble getting definitions

[remitbri]

I'm using 1.4.2
It used to be fine with 1.3.0, but it seems with 1.4.2 I have troubles with getting the definition of (and jumping to) functions/records/etc, and the references. I'd say it happens when the function/record/etc is within a module which is outside the current module, but within the repo. If I hover the thing and press option I can't jump to its location, etc.

Fun facts

• I still get the type! (ex in a lens when I hover the function/record/etc)
• Dev dependencies are fine. (ex I can jump to the definition of React or useEffect in React.useEffect(() => {…})

[zth]

Can you set up a minimal reproduction somehow?

[remitbri]

Yep. Say I've got

bsconfig.json
node_modules/
src/

(etc)

src/Bar.Res

let sub = (a, b) => a - b

src/Foo.res

Bar.sub(4, 5)->ignore

in Foo.res, I've got the lens telling me sub is (int, int) => int, but I can't jump to its definition (in Bar.res)

[igna92ts]

Im having this issue as well

[cristianoc]

Please use the configuration option to set the path to the binary, and see if that helps.
Depending on the answer, we'l learn something new.

[cristianoc]

Yep. Say I've got

bsconfig.json
node_modules/
src/

(etc)

src/Bar.Res

let sub = (a, b) => a - b

src/Foo.res

Bar.sub(4, 5)->ignore

in Foo.res, I've got the lens telling me sub is (int, int) => int, but I can't jump to its definition (in Bar.res)

We have an entire set of tests that correspond to that abstract description.
Would you try the project in analysis/tests see if you have this issue?

[remitbri]

Please use the configuration option to set the path to the binary, and see if that helps.

I've set the path properly (I know since the previous tries were met with a "can't find…"), but it hasn't improved the situation.

Would you try the project in analysis/tests see if you have this issue?

That is puzzling, everything works (say with Cross.res)

[cristianoc]

Good so next step is figure out what's different in your project.
Then report back.

[remitbri]

On the off chance, I upgraded my hello world test repo to 10.0.0-beta.3, but nope.

[WhyThat]

Hello, I found one way to reproduce the bug,
When namespace is set to true in the bsconfig, not sure if it's the same for you @remitbri

[remitbri]

Indeed! Good catch, @WhyThat . The analysis/tests project doesn't have the flag, my "hello world" repo has one - if I remove it everything's ok.

[cristianoc]

There used to be some namespace tests. So this might be relatively recent.

[cristianoc]

I don't think the compiler has changed anything about namespaces. Or at least I don't remember.

[fhammerschmidt]

I just used the workspace-project and tried to execute the analysis binary on it.

With the current master, I get this:

➜  workspace-project git:(master) ✗ ../../_build/install/default/bin/rescript-editor-analysis definition app/src/App.res 0 22          
null

With version 1.3.0, I get this:

➜  workspace-project git:(master) ✗ ../../_build/install/default/bin/rescript-editor-analysis_1.3.0.exe definition app/src/App.res 0 22
{"uri": "file://./node_modules/myplugin/src/Promise.res", "range": {"start": {"line": 0, "character": 0}, "end": {"line": 0, "character": 0}}}

I also downgraded the project to 9.1.4 and did a fresh build, same outcome.
So the regression has to be in the analysis binary, not in the compiler.

[zth]

I'm not at the computer for a while, but maybe someone could do a git bisect and find what commit caused it? Should be fairly fast, it's not that many commits between 1.3.0 and 1.4.0.

[fhammerschmidt]

I would never have guessed that one:

➜  rescript-vscode git:(026e27d) ✗ git bisect good
4f072736099fa8842f05643b289de005f9193bdb is the first bad commit
commit 4f072736099fa8842f05643b289de005f9193bdb
Author: Cristiano Calcagno <cristianoc@users.noreply.github.com>
Date:   Sat Jun 4 05:26:20 2022 +0200

    Remove more infix.

 analysis/src/FindFiles.ml | 11 +++++------
 analysis/src/Infix.ml     |  4 ----
 2 files changed, 5 insertions(+), 10 deletions(-)

Link to commit