Deprecation messages don't show in intellisense popup

[tom-sherman]

This function is tagged with

[@@deprecated "This function will soon be deprecated. Please, use `List.keepWithIndex` instead."]

However this message doesn't show in the popup.

[chenglou]

cc @cristianoc @ryyppy might need some collabs for this

[cristianoc]

Support for autocomplete and hover here: rescript-lang/rescript-editor-support#76

For the missing message in the problems part, perhaps the warning message should be printed differently. Edit: indeed it has an indentation issue.

[cristianoc]

CC @chenglou

[chenglou]

Oh man I totally forgot it was the indent thing... sorry I'll look into it

[chenglou]

K I'm fixing the warning indentation, but then we'd end up with duplicated deprecation message if we merge rescript-lang/rescript-editor-support#76? Yours on hover, mine in diagnostics which also appears on hover

[cristianoc]

It could be removed from hover, though the hover already shows its own block with types and doc comments, and can as well show the deprecation message as part of that block for completeness. Either way.

[chenglou]

For posteriority, this is what it looks like with duplicated warnings:

The rationale to remove it from the editor binary side, instead of on the diagnostics parsing side, is that the latter respects whichever bsconfig setting regarding suppressing deprecation warnings. Although the former looks better in the screenshot...

[chenglou]

Fixed