Rename silently fails for renaming a module that's a file name

[chenglou]

cc @amiralies

This should either work, or we should put up an error message. Whichever one's safer and simpler.

[amiralies]

WorkspaceEditsupports file renames, I think we should use that if that's trivial. I'll take a look proabably this week.

[amiralies]

first we need to fix references for file/top-level modules.

rescript-vscode/analysis/src/References.ml

Lines 467 to 468 in 98ec36b

	| Typed (_, _, NotFound) | LModule NotFound | TopLevelModule _ | Constant _ ->
	[]

[cristianoc]

@amiralies
In examples, references to file-level modules seem to work.
Is there an example showing cases where they don't work?

[cristianoc]

This is what a reference to a file looks like:

{"uri": "Foo.res", "range": {"start": {"line": 0, "character": 0}, "end": {"line": 0, "character": 0}}}

Perhaps the reference should have a different format?

[amiralies]

Trying to get references to a file level module results in an empty array for me.

[cristianoc]

What does the example look like?

[amiralies]

Main.res :

let x = AnotherModule.b

AnotherModule.res:

let b = 3

cmd:

rescript-editor-analysis.exe references src/Main.res 0 15

[amiralies]

perhaps you are running definition command?

[cristianoc]

Thanks you're right.
Added that as an example, to start taking a look:
#248

[cristianoc]

@amiralies in the PR #248, it finds:

[{"uri": "References.res", "range": {"start": {"line": 0, "character": 0}, "end": {"line": 0, "character": 0}}}]

which is something, but it would try to go rename at position (0,0).
Any idea of what format should represent the entire file?

[cristianoc]

I guess there isn't really a way to reference an entire file, as that's a peculiarity of ocaml's module system.
And perhaps the best option is to issue an error message.

[amiralies]

aside from reference to the file-module itself we should find references in other files to that file, if that's not possible I think it's okay for now to show error message.