Skip to content

Fix incorrect type definitions in useCallback #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
May 24, 2023
Merged

Fix incorrect type definitions in useCallback #97

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
d3cfc22
fix incorrect type definitions in useCallback
mununki May 23, 2023
e6792a5
changelog
mununki May 23, 2023
7ee684c
'callback
mununki May 23, 2023
f1422b4
remove useCallback0-7
mununki May 23, 2023
433a290
Revert "remove useCallback0-7"
mununki May 23, 2023
c2e6788
deprecate useCallback0-7, add 'dep
mununki May 23, 2023
2c40d7e
changelog
mununki May 23, 2023
0ea62b1
Update CHANGELOG.md
mununki May 23, 2023
70c1ea5
fix deprecation message
mununki May 23, 2023
1645b13
onEveryRender hooks binding
mununki May 24, 2023
fcc50d7
useEffectOnEveryRender in router
mununki May 24, 2023
40ba48d
fix useEffect in router
mununki May 24, 2023
358b462
Update CHANGELOG.md
mununki May 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
#### :bug: Bug Fix

- Fixed children type for `Fragment`, `StrictMode` and `Suspense`.
- Fixed the incorrect type definitions for `React.useCallback`

#### :nail_care: Polish

Expand Down
8 changes: 4 additions & 4 deletions src/React.res
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,10 +262,10 @@ external useCallback4: ('f, ('a, 'b, 'c, 'd)) => 'f = "useCallback"
external useCallback5: ('f, ('a, 'b, 'c, 'd, 'e)) => 'f = "useCallback"

@module("react")
external useCallback6: ('f, ('a, 'b, 'c, 'd, 'e, 'f)) => 'f = "useCallback"
external useCallback6: ('callback, ('a, 'b, 'c, 'd, 'e, 'f)) => 'callback = "useCallback"

@module("react")
external useCallback7: ('f, ('a, 'b, 'c, 'd, 'e, 'f, 'g)) => 'f = "useCallback"
external useCallback7: ('callback, ('a, 'b, 'c, 'd, 'e, 'f, 'g)) => 'callback = "useCallback"

@module("react")
external useContext: Context.t<'any> => 'any = "useContext"
Expand Down Expand Up @@ -422,10 +422,10 @@ module Uncurried = {
external useCallback5: ('f, ('a, 'b, 'c, 'd, 'e)) => 'f = "useCallback"

@module("react")
external useCallback6: ('f, ('a, 'b, 'c, 'd, 'e, 'f)) => 'f = "useCallback"
external useCallback6: ('callback, ('a, 'b, 'c, 'd, 'e, 'f)) => 'callback = "useCallback"

@module("react")
external useCallback7: ('f, ('a, 'b, 'c, 'd, 'e, 'f, 'g)) => 'f = "useCallback"
external useCallback7: ('callback, ('a, 'b, 'c, 'd, 'e, 'f, 'g)) => 'callback = "useCallback"
}

@set
Expand Down
8 changes: 4 additions & 4 deletions src/v3/React_V3.res
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,10 +262,10 @@ external useCallback4: ('f, ('a, 'b, 'c, 'd)) => 'f = "useCallback"
external useCallback5: ('f, ('a, 'b, 'c, 'd, 'e)) => 'f = "useCallback"

@module("react")
external useCallback6: ('f, ('a, 'b, 'c, 'd, 'e, 'f)) => 'f = "useCallback"
external useCallback6: ('callback, ('a, 'b, 'c, 'd, 'e, 'f)) => 'callback = "useCallback"

@module("react")
external useCallback7: ('f, ('a, 'b, 'c, 'd, 'e, 'f, 'g)) => 'f = "useCallback"
external useCallback7: ('callback, ('a, 'b, 'c, 'd, 'e, 'f, 'g)) => 'callback = "useCallback"

@module("react")
external useContext: Context.t<'any> => 'any = "useContext"
Expand Down Expand Up @@ -368,10 +368,10 @@ module Uncurried = {
external useCallback5: ('f, ('a, 'b, 'c, 'd, 'e)) => 'f = "useCallback"

@module("react")
external useCallback6: ('f, ('a, 'b, 'c, 'd, 'e, 'f)) => 'f = "useCallback"
external useCallback6: ('callback, ('a, 'b, 'c, 'd, 'e, 'f)) => 'callback = "useCallback"

@module("react")
external useCallback7: ('f, ('a, 'b, 'c, 'd, 'e, 'f, 'g)) => 'f = "useCallback"
external useCallback7: ('callback, ('a, 'b, 'c, 'd, 'e, 'f, 'g)) => 'callback = "useCallback"
}

@module("react")
Expand Down