Skip to content

Document array spreads #810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 23, 2024
Merged

Document array spreads #810

merged 3 commits into from
Feb 23, 2024

Conversation

zth
Copy link
Collaborator

@zth zth commented Feb 5, 2024

Available in v11.1.

@zth zth requested a review from fhammerschmidt February 5, 2024 08:09
Copy link

vercel bot commented Feb 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rescript-lang.org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 23, 2024 1:38pm

@zth
Copy link
Collaborator Author

zth commented Feb 5, 2024

Right, can't merge this until it's actually released (tests fail because of the syntax change, that needs a release to work). Let's wait a bit with this then.

@fhammerschmidt
Copy link
Member

The syntax lookup probably needs to have a ...-chapter as well. But not sure if that can even be called spread operator there, since ... also describes a partially applied function.

@zth
Copy link
Collaborator Author

zth commented Feb 5, 2024

Yeah, maybe it'd be more confusing to document it as a single concept like that. We can think about it for a bit.

@fhammerschmidt
Copy link
Member

This can be merged as well?

@zth
Copy link
Collaborator Author

zth commented Feb 23, 2024

@fhammerschmidt I can't seem to find where to update the ReScript version that's used for checking the ReScript code blocks. It needs to be 11.1.0-rc.2 for array spreads to work. Do you know?

@fhammerschmidt
Copy link
Member

Yes, update "rescript-1110" in compilers/package.json

@zth zth merged commit 5d48088 into master Feb 23, 2024
@zth zth deleted the document-array-spreads branch February 23, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants