Responsive Docs Menu API "Types and values" #799
Conversation
src/ApiDocs.res
Outdated
| module RightSidebar = { | ||
| @react.component | ||
| let make = (~items: array<item>) => { | ||
| switch items->Js.Array2.length === 0 { |
There was a problem hiding this comment.
redundant length check, you have them as well in both places where you use <RightSidebar />
There was a problem hiding this comment.
I checked because I don't want to show the "Types and Values" text when it is empty.
There was a problem hiding this comment.
Everywhere where you use the RightSidebar component, you already ensure that the items are not empty. That's why I suggested to remove the one in RightSidebar.
There was a problem hiding this comment.
Oh right. Removed 5062cd8
|
I just tested it and am not sure why you do not like it. |
|
@aspeddro is attempting to deploy a commit to the ReScript Association Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Add a submenu with a link to the value/type in each module:
I didn't really like how it turned out, so any suggestions are welcome.