Attempt: Upgrade to NextJS version 13 #645
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update next-transpile-modules to version 9 - Remove .babelrc file - Remove esbuild-loader, path, fs, target, future from next.config.js - Add SWC in next.config.js
* Update next-transpile-modules to v.10 * Switch to @next/mdx * Adjust transpileModules * Remove child <a> tags of <link>
…-lang.org into nextjs-12" This reverts commit 5334930, reversing changes made to 25d4a35.
|
Just as a side-note, the frontmatter parsing seems to be broken as well: But this is a good start! |
ryyppy
reviewed
Feb 3, 2023
| @@ -1,7 +1,7 @@ | |||
| --- | |||
| title: Migrate from JSX v3 | |||
| description: "Migrate from JSX v3" | |||
| canonical: "/docs/react/latest/migrate-react" | |||
| canonical: "/docs/react/latest/migrate-from-v3" | |||
There was a problem hiding this comment.
I am very confused by this change. Current master has a latest/migrate-react. So this change is essentially adding a new page migrate-from-v3 (which I agree is a way better url, although I'd probably call it migrate-from-jsx-3 instead).
Now migrate-react is a thing for quite a while, ppl may still refer to it, so we might need a redirection to this page via the nextjs config to not break urls.
This is quite an unrelated change, so I'd want this to be a separate PR to master.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an attempt to upgrade this repo’s NextJS version to the latest (v.13).
The idea stemmed from the talk which initially desired to integrate the internationalization function for rescript-lang.org. I remember the ReScript team wanted the NextJS upgrade to happen with the i8n, so we (with @namenu & @mununki) thought why don’t we help?
Up to NextJS version 12, the upgrade was decently successful. And to version 13, it’s not completely done since there're a few hydration errors that still exist. Hope this is somewhat helpful to initiate the idea.
This PR,
transpileModulesinnext.config.js(ref)esbuild-loader,path,fs,target,futureinnext.config.jsSWCinnext.config.js.babelrcfile@next/mdx<a>tags of<link>