Skip to content

add DocSearch v3 #534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 30 commits into from
Apr 8, 2024
Merged

Conversation

aspeddro
Copy link
Collaborator

@aspeddro aspeddro commented Jun 24, 2022

Changes

  • Add bindings to @docsearch/react v3

UI Changes

Fix #498
Fix #528
Fix #245
Fix #465

@aspeddro aspeddro marked this pull request as ready for review July 16, 2022 05:01
@ryyppy
Copy link
Member

ryyppy commented Nov 3, 2022

Thanks for the PR.

So generally this looks good, although I am not entirely convinced about algolia's way of design here and at some point I wanted to have something custom tailored. Anyways, the only nitpick: This doesn't really fix #465 since we'd need to fix the Algolia crawling and UI mapping first (as stated in your TODO section). The new experience is even more confusing, since it will render empty rows.

image

Still wondering if we should merge this and then follow up with the relevant index changes.

@aspeddro
Copy link
Collaborator Author

aspeddro commented Nov 3, 2022

So generally this looks good, although I am not entirely convinced about algolia's way of design here and at some point I wanted to have something custom tailored.

Okay, I'll refactor it.

This doesn't really fix #465 since we'd need to fix the Algolia crawling and UI mapping first (as stated in your TODO section).

Sure, Fixed.

The new experience is even more confusing, since it will render empty rows.

This is due to the new version of the extractor, which must be updated.

@aspeddro
Copy link
Collaborator Author

aspeddro commented Nov 3, 2022

Still wondering if we should merge this and then follow up with the relevant index changes.

Is it possible to create a new extractor so that we can test it?

@ryyppy
Copy link
Member

ryyppy commented Nov 3, 2022

I have access to the new editor experience on the algolia website. Will need to update the api keys and then try to work my way around the crawling configuration. Will let you know as soon as I got something going.

@aspeddro
Copy link
Collaborator Author

Now the design is more personalized. I changed it to the DocSearchModal component.

@aspeddro aspeddro marked this pull request as ready for review February 2, 2023 21:39
@aspeddro
Copy link
Collaborator Author

aspeddro commented Feb 2, 2023

2e22535 add an alternative to not rendering empty lines.

image

@aspeddro
Copy link
Collaborator Author

I don't think we need to change the crawler. Git tags are displayed.

image

@ryyppy
Copy link
Member

ryyppy commented Nov 12, 2023

can we only show results for the latest version? We may make this dependent on the current version that is being browsed, but for the start, only latest would be great.

Copy link

vercel bot commented Feb 1, 2024

@aspeddro is attempting to deploy a commit to the ReScript Association Team on Vercel.

A member of the Team first needs to authorize it.

@aspeddro
Copy link
Collaborator Author

aspeddro commented Feb 5, 2024

Ready for review

@fhammerschmidt fhammerschmidt requested a review from ryyppy February 5, 2024 14:44
Copy link

vercel bot commented Apr 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rescript-lang.org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 8, 2024 7:43am

@fhammerschmidt fhammerschmidt merged commit b14553a into rescript-lang:master Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants