-
-
Notifications
You must be signed in to change notification settings - Fork 252
add DocSearch v3 #534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add DocSearch v3 #534
Conversation
Thanks for the PR. So generally this looks good, although I am not entirely convinced about algolia's way of design here and at some point I wanted to have something custom tailored. Anyways, the only nitpick: This doesn't really fix #465 since we'd need to fix the Algolia crawling and UI mapping first (as stated in your TODO section). The new experience is even more confusing, since it will render empty rows. Still wondering if we should merge this and then follow up with the relevant index changes. |
Okay, I'll refactor it.
Sure, Fixed.
This is due to the new version of the extractor, which must be updated. |
Is it possible to create a new extractor so that we can test it? |
I have access to the new editor experience on the algolia website. Will need to update the api keys and then try to work my way around the crawling configuration. Will let you know as soon as I got something going. |
Now the design is more personalized. I changed it to the |
2e22535 add an alternative to not rendering empty lines. |
can we only show results for the latest version? We may make this dependent on the current version that is being browsed, but for the start, only latest would be great. |
@aspeddro is attempting to deploy a commit to the ReScript Association Team on Vercel. A member of the Team first needs to authorize it. |
Ready for review |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Changes
@docsearch/react
v3UI Changes
Search icon is now visible in any width. Before, it was not visible between 599px and 766px
Remove the search icon from the mobile menu and keep it always visible. This is the behavior on sites like reactnative.dev, tailwindcss, and reactjs
Update record extractor
Fix #498
Fix #528
Fix #245
Fix #465