Skip to content

test: fix printing of non-JSON values #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

glennsl
Copy link
Contributor

@glennsl glennsl commented Mar 6, 2023

When working with NaNs and such I got tired of the test framework misleadingly printing null instead, because it uses JSON.stringify which does weird things with values that are not valid JSON. This fixes that.

@zth zth merged commit e042948 into rescript-lang:main Mar 6, 2023
@glennsl glennsl deleted the test/fix-printing-of-non-json-values branch March 6, 2023 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants