Skip to content

Flesh out Console #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Feb 19, 2023
Merged

Flesh out Console #56

merged 17 commits into from
Feb 19, 2023

Conversation

glennsl
Copy link
Contributor

@glennsl glennsl commented Feb 19, 2023

Fixes #55

Copy link
Collaborator

@zth zth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you! Can we revert the unrelated formatting changes in Array and Math?

@glennsl
Copy link
Contributor Author

glennsl commented Feb 19, 2023

Done. Not sure why Github doesn't update, but the commits have been removed from the branch that the PR points to.

It's going to really annoy me if the formatting isn't fixed elsewhere though, since I'll constantly have thee uncommitted formatting changes hanging around. It seems like a good idea to set up CI workflow to check formatting, so as to avoid this in the future.

@zth
Copy link
Collaborator

zth commented Feb 19, 2023

Sure, I don't mind that. Would you be up for PR:ing CI and a command in package.json/scripts for formatting everything?

@zth zth merged commit 9517829 into rescript-lang:main Feb 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Console bindings incomplete
2 participants