Docs for Promise #41
Docs for Promise #41
Conversation
aspeddro
commented
Feb 16, 2023
aspeddro
commented
- Add examples header
- Add MDN links
- Add module docstring
|
Is this ready for review? |
| */ | ||
| external done: promise<'a> => unit = "%ignore" | ||
|
|
||
| // TODO: add docstring |
There was a problem hiding this comment.
These are reserved for the compiler. Can be removed from here as not part of the public api.
Assuming removing them does not stop async code from compiling after opening Core: one just needs to check this. I think it's OK as the Js.* namespace is still visible.
There was a problem hiding this comment.
We can try again, but IIRC the reason I added them was because async/await didn't work otherwise. Maybe that's something that can be fixed though.
There was a problem hiding this comment.
Can you check again? And if so add an issue to the compiler.
There was a problem hiding this comment.
It seems to work just fine without them. Interesting, I wonder what errored back when I decided to add them... Anyway, we can go ahead and just remove them from Core. I'll do that directly in main after this PR is merged.
|
Ready for review |
