Can't use genType

[jmagaram]

GenType generates import statements for Core modules that don't work. What do I need to do to make this work?

I see in https://rescript-lang.org/docs/gentype/latest/usage#dependent-projects--libraries it says "The library must have been published with the .gen.ts files created by genType."

I've got a file ReactFirebaseHooks.res with this in it AND my bsconfig.json has "bsc-flags": ["-open RescriptCore"]

@gentype.import("react-firebase-hooks/auth") @genType.as("useAuthState")
external useAuthState: Auth.t => (Null.t<Auth.user>, bool, option<Error.t>) =
  "useAuthState"

This leads to the following in my ReactFirebaseHooks.gen.tsx...

import type {t as Error_t} from './Error.gen'; // does not exist
import type {t as Null_t} from './Null.gen'; // does not exist

If I change the code to reference Core__Error.gen this is probably closer to the desired result, but still doesn't work.

import type {t as Core__Error_t} from '@rescript/core/src/Core__Error.gen'; // does not exist
import type {t as Core__Null_t} from '@rescript/core/src/Core__Null.gen'; // does not exist

I tried taking out the -open RescriptCore but it still doesn't work. I tried adding node_modules/~rescript/core/src to bsconfig.json but this shouldn't be necessary and still doesn't work.

[zth]

Hmm, IIRC this was recently fixed. What ReScript compiler version are you on?

[jmagaram]

In my package.json I see ^10.1.3. My script is rescript build -w.

[zth]

Could you try 10.1.4 explicitly?

[jmagaram]

Same problem

[jmagaram]

Did a clean, verified with npm list. The .gen.tsx file...

import type {t as Core__Error_t} from '@rescript/core/src/Core__Error.gen';
import type {t as Core__Null_t} from '@rescript/core/src/Core__Null.gen';

[jmagaram]

I have the same problem with a different package. Does the author of the package need to put @gentype everywhere or is the compiler supposed to handle this?

[cristianoc]

Not sure what the issue is here.
#129

[jmagaram]

I'll try again with a repo scenario but your example doesn't look like what I'm talking about - just reading on my phone. Array isn't a problem because it is built in. But Error.t and Null.t are not so typescript doesn't know where to find them. . Could you clarify if that gentyoe doc comment is still true that the library author must generate and publish the .gen files with their package?

[jmagaram]

Just to be clear I'm trying to use Core in another project when it lives in the node_modules folder.

[jmagaram]

Repo scenarios here https://github.com/jmagaram/core-gentype
Am I supposed to make shims for everything in Core?

[cristianoc]

There was an issue to explore that scenario: picking up annotations from dependencies. But there was no concrete work on that.
So it's about first finding out what's the current situation and take it from there.

[cristianoc]

@jmagaram I should look for the analogous discussion in the genType repo, where exactly these kinds of issues were discussed.
I think this might be a good time to look a bit more in depth into that. Because we might have the opportunity to, for example, make it work well for at least Core when used as a dependency. And for other projects after that.
Not sure if you're time/interest to help, but starting from figuring out current status and how one would expect this to work would be a first step.
Specifically, if a dependency has genType annotations then 2 things will happen:

1. .gen.tsx files should be checked in or anyhow produces so they are available.
2. one might need to access relevant type information from those files in the dependency. To see if this works one can try this: use some gentype'd value or type from another file in the same project. Then do it for another file in a dependency. Is the behaviour the same
3. Further ahead, there's the opportunity now after the latest changes for genType to conform to the way that TypeScript expects the .d.ts to be in a project. Particularly a dependency. So one can see if that is possible to do in future. So one would be able ideally to consume a dependency transparently from TS and from ReScript