Skip to content

Do not offer incompatible Core versions for older ReScript versions #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 20, 2024
Merged

Do not offer incompatible Core versions for older ReScript versions #50

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
741b2a4
Do not offer incompatible Core versions for older ReScript versions
cknitt Apr 20, 2024
cd4fa8e
Version 1.7.1
cknitt Apr 20, 2024
a32d8c0
Use Core 1.3.0
cknitt Apr 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "create-rescript-app",
"version": "1.7.0",
"version": "1.7.1",
"description": "Quickly create new ReScript apps from project templates.",
"main": "out/create-rescript-app.mjs",
"scripts": {
Expand Down Expand Up @@ -37,7 +37,7 @@
},
"devDependencies": {
"@clack/prompts": "0.7.0",
"@rescript/core": "^1.2.0",
"@rescript/core": "^1.3.0",
"@rollup/plugin-commonjs": "^25.0.7",
"@rollup/plugin-node-resolve": "^15.2.3",
"@rollup/plugin-terser": "^0.4.4",
Expand Down
14 changes: 14 additions & 0 deletions src/RescriptVersions.res
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,15 @@ let getPackageVersions = async (packageName, range) => {
versions
}

let getCompatibleRescriptCoreVersions = (~rescriptVersion, ~rescriptCoreVersions) =>
if CompareVersions.compareVersions(rescriptVersion, "11.1.0")->Ordering.isLess {
rescriptCoreVersions->Array.filter(coreVersion =>
CompareVersions.compareVersions(coreVersion, "1.3.0")->Ordering.isLess
)
} else {
rescriptCoreVersions
}

let promptVersions = async () => {
let s = P.spinner()

Expand All @@ -44,6 +53,11 @@ let promptVersions = async () => {
})->P.resultOrRaise
}

let rescriptCoreVersions = getCompatibleRescriptCoreVersions(
~rescriptVersion,
~rescriptCoreVersions,
)

let rescriptCoreVersion = switch rescriptCoreVersions {
| [version] => version
| _ =>
Expand Down
2 changes: 1 addition & 1 deletion templates/rescript-template-basic/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"author": "",
"license": "MIT",
"dependencies": {
"@rescript/core": "^1.2.0",
"@rescript/core": "^1.3.0",
"rescript": "^11.1.0"
}
}
16 changes: 8 additions & 8 deletions templates/rescript-template-nextjs/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion templates/rescript-template-nextjs/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"author": "Patrick Ecker <ryyppy@users.noreply.github.com>",
"license": "Apache-2.0",
"dependencies": {
"@rescript/core": "^1.2.0",
"@rescript/core": "^1.3.0",
"@rescript/react": "^0.12.1",
"next": "^14.0.4",
"react": "^18.2.0",
Expand Down
10 changes: 5 additions & 5 deletions templates/rescript-template-vite/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion templates/rescript-template-vite/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"preview": "vite preview"
},
"dependencies": {
"@rescript/core": "^1.2.0",
"@rescript/core": "^1.3.0",
"@rescript/react": "^0.12.1",
"react": "^18.2.0",
"react-dom": "^18.2.0",
Expand Down