Skip to content

chore: Docusaurus with webpack 5 #1714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 29, 2021
Merged

Conversation

slorber
Copy link
Contributor

@slorber slorber commented Apr 16, 2021

Use an unreleased version of Docusaurus to test the webpack5 support works for this site.

See also facebook/docusaurus#4089

Note: I'm not sure to understand how Netlify is set-up, you may want to cache the webpack5 cache with a similar config than reduxjs/redux#4067

@netlify
Copy link

netlify bot commented Apr 16, 2021

Deploy preview for react-redux-docs ready!

Built with commit 2ea2d7a

https://deploy-preview-1714--react-redux-docs.netlify.app

@timdorr
Copy link
Member

timdorr commented May 1, 2021

Poked at some bad front matter for you. Not sure why GitHub is continually asking me to approve your builds, as I'd figure it would remember the first time I say it's good.

LGTM

@slorber slorber marked this pull request as ready for review May 1, 2021 16:21
@slorber
Copy link
Contributor Author

slorber commented May 1, 2021

thanks

we recently added a more strict validation of frontmatter, do you think we should allow empty sidebar_label like before? What was the intention? Also why your first fix didn't work?

@timdorr
Copy link
Member

timdorr commented May 1, 2021

It didn't fall back to the title in the first fix. You can check out that revision and build it locally to see for yourself. Might be worth a bug fix.

As for the expected behavior, I'd say null should behave similarly to undefined. That feels the most natural to me. I'm not sure why someone would add sidebar_label without filling it in, but that seems like a reasonable fallback.

@slorber
Copy link
Contributor Author

slorber commented May 4, 2021

thanks for the feedback :)

Let me know if I can do anything else for this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants