Skip to content

Redux-React Basic Tutorial issues #1684

Open
@cniemann88

Description

@cniemann88

Not quiet sure where else to put this.

For the Basic Tutorial https://react-redux.js.org/introduction/basic-tutorial there are 3 issues.

Issue 1: The Sandbox Code: https://codesandbox.io/s/6vwyqrpqk3 uses react: 16.4.2, but needs at least 16.8.4 because of .memo()

Issue 2: The tutorial implements the connection for the VisibilityFilters, but it omits setting the filters
const VisibilityFilters = ({ activeFilter, setFilter }) => {

<span
key={`visibility-filter-${currentFilter}`}
className={cx(
  "filter",
  currentFilter === activeFilter && "filter--active"
)}
onClick={() => {} /** waiting for setFilter handler*/} <------this should be mentioned in the Tutorial, or filled in
>
{currentFilter}
</span>

Issue 3: Similar to issue 2, the tutorial doesnt implement the toggleTodo() in Todo.js.

Thanks!

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions