Skip to content

[Async] Multi Exec on cluster #3649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
May 27, 2025
Merged

Conversation

vladvildanov
Copy link
Collaborator

@vladvildanov vladvildanov commented May 19, 2025

Pull Request check-list

Please make sure to review and check all of these items:

  • Do tests and lints pass with this change?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Async implementation of #3611

@vladvildanov vladvildanov requested a review from Copilot May 20, 2025 14:50
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces asynchronous support for cluster transactions, enhancing error handling during operations such as migrations and connection issues.

  • Added comprehensive async tests for cluster transactions covering AskError, ExecAbortError, and connection errors.
  • Updated behavior of the cluster pipeline tests by removing the deprecated transaction flag check.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
tests/test_asyncio/test_cluster_transaction.py Added extensive async transaction tests with various error cases.
tests/test_asyncio/test_cluster.py Removed deprecated transaction check and adjusted the behavior.

@petyaslavova petyaslavova merged commit bc7de60 into master May 27, 2025
69 of 70 checks passed
@petyaslavova petyaslavova deleted the vv-async-multi-exec-cluster branch May 27, 2025 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
async feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants