DOC-4494 SADD and SMEMBERS command examples #3242

andy-stark-redis · 2025-01-22T13:24:50Z

DOC-4494 and DOC-4436.

Go examples for the SADD and SMEMBERS command pages.

doctests/cmds_set_test.go

ndyakov

Hey @andy-stark-redis , should we rename the variables based on the comments I left?

andy-stark-redis · 2025-02-07T10:00:29Z

Hey @andy-stark-redis , should we rename the variables based on the comments I left?

@ndyakov The reason for the names is that all the variables with names like sMembersResultxx are in the examples for the SMEMBERS command page and likewise for sAddResultxx, etc. If you think it's confusing then we could use a different naming convention, but we probably don't want to name the result variables after the commands that return them, in general.

ndyakov · 2025-02-10T12:28:00Z

@andy-stark-redis let's try to come up with another naming convention. I do think this can be confusing to someone reading the code. Maybe something like mysetMembers for the result of the SMembers(...,"myset") ? We can brainstorm that on slack if you would like?

ndyakov · 2025-02-21T11:55:44Z

@andy-stark-redis are we keeping those variable names or we are waiting for an update on this PR?

andy-stark-redis · 2025-02-21T12:49:39Z

@andy-stark-redis are we keeping those variable names or we are waiting for an update on this PR?

@ndyakov I've added a new commit to change the names already. I think they are now in line with what you suggested but I'll change them if you still think they are unhelpful.

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/redis/go-redis/v9](https://github.com/redis/go-redis) | require | minor | `v9.7.3` -> `v9.8.0` | --- ### Release Notes <details> <summary>redis/go-redis (github.com/redis/go-redis/v9)</summary> ### [`v9.8.0`](https://github.com/redis/go-redis/releases/tag/v9.8.0) [Compare Source](redis/go-redis@v9.7.3...v9.8.0) ### 9.8.0 (2025-04-30) #### 🚀 Highlights - **Redis 8 Support**: Full compatibility with Redis 8.0, including testing and CI integration - **Enhanced Hash Operations**: Added support for new hash commands (`HGETDEL`, `HGETEX`, `HSETEX`) and `HSTRLEN` command - **Search Improvements**: Enabled Search DIALECT 2 by default and added `CountOnly` argument for `FT.Search` #### ✨ New Features - Added support for new hash commands: `HGETDEL`, `HGETEX`, `HSETEX` ([#3305](redis/go-redis#3305)) - Added `HSTRLEN` command for hash operations ([#2843](redis/go-redis#2843)) - Added `Do` method for raw query by single connection from `pool.Conn()` ([#3182](redis/go-redis#3182)) - Prevent false-positive marshaling by treating zero time.Time as empty in isEmptyValue ([#3273](redis/go-redis#3273)) - Added FailoverClusterClient support for Universal client ([#2794](redis/go-redis#2794)) - Added support for cluster mode with `IsClusterMode` config parameter ([#3255](redis/go-redis#3255)) - Added client name support in `HELLO` RESP handshake ([#3294](redis/go-redis#3294)) - **Enabled Search DIALECT 2 by default** ([#3213](redis/go-redis#3213)) - Added read-only option for failover configurations ([#3281](redis/go-redis#3281)) - Added `CountOnly` argument for `FT.Search` to use `LIMIT 0 0` ([#3338](redis/go-redis#3338)) - Added `DB` option support in `NewFailoverClusterClient` ([#3342](redis/go-redis#3342)) - Added `nil` check for the options when creating a client ([#3363](redis/go-redis#3363)) #### 🐛 Bug Fixes - Fixed `PubSub` concurrency safety issues ([#3360](redis/go-redis#3360)) - Fixed panic caused when argument is `nil` ([#3353](redis/go-redis#3353)) - Improved error handling when fetching master node from sentinels ([#3349](redis/go-redis#3349)) - Fixed connection pool timeout issues and increased retries ([#3298](redis/go-redis#3298)) - Fixed context cancellation error leading to connection spikes on Primary instances ([#3190](redis/go-redis#3190)) - Fixed RedisCluster client to consider `MASTERDOWN` a retriable error ([#3164](redis/go-redis#3164)) - Fixed tracing to show complete commands instead of truncated versions ([#3290](redis/go-redis#3290)) - Fixed OpenTelemetry instrumentation to prevent multiple span reporting ([#3168](redis/go-redis#3168)) - Fixed `FT.Search` Limit argument and added `CountOnly` argument for limit 0 0 ([#3338](redis/go-redis#3338)) - Fixed missing command in interface ([#3344](redis/go-redis#3344)) - Fixed slot calculation for `COUNTKEYSINSLOT` command ([#3327](redis/go-redis#3327)) - Updated PubSub implementation with correct context ([#3329](redis/go-redis#3329)) #### 📚 Documentation - Added hash search examples ([#3357](redis/go-redis#3357)) - Fixed documentation comments ([#3351](redis/go-redis#3351)) - Added `CountOnly` search example ([#3345](redis/go-redis#3345)) - Added examples for list commands: `LLEN`, `LPOP`, `LPUSH`, `LRANGE`, `RPOP`, `RPUSH` ([#3234](redis/go-redis#3234)) - Added `SADD` and `SMEMBERS` command examples ([#3242](redis/go-redis#3242)) - Updated `README.md` to use Redis Discord guild ([#3331](redis/go-redis#3331)) - Updated `HExpire` command documentation ([#3355](redis/go-redis#3355)) - Featured OpenTelemetry instrumentation more prominently ([#3316](redis/go-redis#3316)) - Updated `README.md` with additional information ([#310ce55](redis/go-redis@310ce55)) #### ⚡ Performance and Reliability - Bound connection pool background dials to configured dial timeout ([#3089](redis/go-redis#3089)) - Ensured context isn't exhausted via concurrent query ([#3334](redis/go-redis#3334)) #### 🔧 Dependencies and Infrastructure - Updated testing image to Redis 8.0-RC2 ([#3361](redis/go-redis#3361)) - Enabled CI for Redis CE 8.0 ([#3274](redis/go-redis#3274)) - Updated various dependencies: - Bumped golangci/golangci-lint-action from 6.5.0 to 7.0.0 ([#3354](redis/go-redis#3354)) - Bumped rojopolis/spellcheck-github-actions ([#3336](redis/go-redis#3336)) - Bumped golang.org/x/net in example/otel ([#3308](redis/go-redis#3308)) - Migrated golangci-lint configuration to v2 format ([#3354](redis/go-redis#3354)) #### ⚠️ Breaking Changes - **Enabled Search DIALECT 2 by default** ([#3213](redis/go-redis#3213)) - Dropped RedisGears (Triggers and Functions) support ([#3321](redis/go-redis#3321)) - Dropped FT.PROFILE command that was never enabled ([#3323](redis/go-redis#3323)) #### 🔒 Security - Fixed network error handling on SETINFO (CVE-2025-29923) ([#3295](redis/go-redis#3295)) #### 🧪 Testing - Added integration tests for Redis 8 behavior changes in Redis Search ([#3337](redis/go-redis#3337)) - Added vector types INT8 and UINT8 tests ([#3299](redis/go-redis#3299)) - Added test codes for search_commands.go ([#3285](redis/go-redis#3285)) - Fixed example test sorting ([#3292](redis/go-redis#3292)) #### 👥 Contributors We would like to thank all the contributors who made this release possible: [@alexander-menshchikov](https://github.com/alexander-menshchikov), [@EXPEbdodla](https://github.com/EXPEbdodla), [@afti](https://github.com/afti), [@dmaier-redislabs](https://github.com/dmaier-redislabs), [@four_leaf_clover](https://github.com/four_leaf_clover), [@alohaglenn](https://github.com/alohaglenn), [@gh73962](https://github.com/gh73962), [@justinmir](https://github.com/justinmir), [@LINKIWI](https://github.com/LINKIWI), [@liushuangbill](https://github.com/liushuangbill), [@golang88](https://github.com/golang88), [@gnpaone](https://github.com/gnpaone), [@ndyakov](https://github.com/ndyakov), [@nikolaydubina](https://github.com/nikolaydubina), [@oleglacto](https://github.com/oleglacto), [@andy-stark-redis](https://github.com/andy-stark-redis), [@rodneyosodo](https://github.com/rodneyosodo), [@dependabot](https://github.com/dependabot), [@rfyiamcool](https://github.com/rfyiamcool), [@frankxjkuang](https://github.com/frankxjkuang), [@fukua95](https://github.com/fukua95), [@soleymani-milad](https://github.com/soleymani-milad), [@ofekshenawa](https://github.com/ofekshenawa), [@khasanovbi](https://github.com/khasanovbi) </details> --- ### Configuration 📅 **Schedule**: Branch creation - Between 12:00 AM and 03:59 AM ( * 0-3 * * * ) (UTC), Automerge - Between 12:00 AM and 03:59 AM ( * 0-3 * * * ) (UTC). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/7739 Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org> Co-authored-by: Renovate Bot <forgejo-renovate-action@forgejo.org> Co-committed-by: Renovate Bot <forgejo-renovate-action@forgejo.org>

andy-stark-redis added 2 commits January 22, 2025 13:03

DOC-4494 added sadd example

538eba8

DOC-4494 sadd and smembers examples

9fd5e1d

andy-stark-redis marked this pull request as ready for review January 22, 2025 16:16

andy-stark-redis requested a review from dmaier-redislabs as a code owner January 22, 2025 16:16

andy-stark-redis requested a review from vladvildanov January 22, 2025 16:16

andy-stark-redis self-assigned this Jan 22, 2025

andy-stark-redis added the docs-review label Jan 22, 2025

andy-stark-redis and others added 4 commits January 23, 2025 16:39

Merge branch 'master' into DOC-4494-set-cmd-examples

56237bb

Merge branch 'master' into DOC-4494-set-cmd-examples

690f492

Merge branch 'master' into DOC-4494-set-cmd-examples

81a84e2

Merge branch 'master' into DOC-4494-set-cmd-examples

d58fe47

ndyakov self-requested a review February 7, 2025 08:43

ndyakov previously approved these changes Feb 7, 2025

View reviewed changes

ndyakov reviewed Feb 7, 2025

View reviewed changes

doctests/cmds_set_test.go Outdated Show resolved Hide resolved

ndyakov reviewed Feb 7, 2025

View reviewed changes

doctests/cmds_set_test.go Outdated Show resolved Hide resolved

ndyakov reviewed Feb 7, 2025

View reviewed changes

andy-stark-redis and others added 2 commits February 7, 2025 10:00

Merge branch 'master' into DOC-4494-set-cmd-examples

e667d5d

Merge branch 'master' into DOC-4494-set-cmd-examples

c2d224e

andy-stark-redis and others added 3 commits February 10, 2025 16:13

Merge branch 'master' into DOC-4494-set-cmd-examples

171b83a

Merge branch 'master' into DOC-4494-set-cmd-examples

2bf2195

DOC-4494 better naming convention for result variables

a5d202b

andy-stark-redis dismissed ndyakov’s stale review via a5d202b February 12, 2025 11:32

andy-stark-redis requested a review from ndyakov February 12, 2025 11:33

andy-stark-redis and others added 3 commits February 18, 2025 14:53

Merge branch 'master' into DOC-4494-set-cmd-examples

beef535

Merge branch 'master' into DOC-4494-set-cmd-examples

55b65d3

Merge branch 'master' into DOC-4494-set-cmd-examples

9b90e09

Merge branch 'master' into DOC-4494-set-cmd-examples

974664e

ndyakov approved these changes Mar 19, 2025

View reviewed changes

Merge branch 'master' into DOC-4494-set-cmd-examples

252ab1d

ndyakov merged commit 74d4f08 into redis:master Mar 19, 2025
16 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

DOC-4494 SADD and SMEMBERS command examples #3242

DOC-4494 SADD and SMEMBERS command examples #3242

Uh oh!

andy-stark-redis commented Jan 22, 2025 •

edited by jira bot

Loading

Uh oh!

Uh oh!

Uh oh!

ndyakov left a comment

Uh oh!

andy-stark-redis commented Feb 7, 2025

Uh oh!

ndyakov commented Feb 10, 2025

Uh oh!

ndyakov commented Feb 21, 2025

Uh oh!

andy-stark-redis commented Feb 21, 2025

Uh oh!

Uh oh!

Uh oh!

DOC-4494 SADD and SMEMBERS command examples #3242

DOC-4494 SADD and SMEMBERS command examples #3242

Uh oh!

Conversation

andy-stark-redis commented Jan 22, 2025 • edited by jira bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ndyakov left a comment

Choose a reason for hiding this comment

Uh oh!

andy-stark-redis commented Feb 7, 2025

Uh oh!

ndyakov commented Feb 10, 2025

Uh oh!

ndyakov commented Feb 21, 2025

Uh oh!

andy-stark-redis commented Feb 21, 2025

Uh oh!

Uh oh!

Uh oh!

andy-stark-redis commented Jan 22, 2025 •

edited by jira bot

Loading