Skip to content

VS Code doesn't call shutdown when exiting the standard client #2472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 27, 2022
Merged

VS Code doesn't call shutdown when exiting the standard client #2472

merged 1 commit into from
May 27, 2022

Conversation

snjeza
Copy link
Collaborator

@snjeza snjeza commented May 26, 2022

Fixes #2471

Signed-off-by: Snjezana Peco snjezana.peco@redhat.com

@snjeza
VS Code doesn't call shutdown when exiting the standard client
78c0270 
Signed-off-by: Snjezana Peco <snjezana.peco@redhat.com>
rgrunber
rgrunber approved these changes May 26, 2022
View reviewed changes
Copy link
Member

@rgrunber rgrunber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This solves the issue for me. I tested multiple times as a packaged vsix as well as in a child vscode instance and it's working again.

@snjeza snjeza merged commit 97b29fa into redhat-developer:master May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgrunber rgrunber rgrunber approved these changes

@gorkem gorkem Awaiting requested review from gorkem

@fbricon fbricon Awaiting requested review from fbricon

@testforstephen testforstephen Awaiting requested review from testforstephen

Assignees
No one assigned
Labels
in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

VS Code doesn't call shutdown when exiting the standard client
2 participants
@snjeza @rgrunber