Translate FAQ/Function and FAQ/Styling #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for vi-reactjs-org ready! Built with commit 00cd756 |
ltmylinh
requested changes
Jun 5, 2019
content/docs/faq-functions.md
Outdated
| > | ||
| >Using `Function.prototype.bind` in render creates a new function each time the component renders, which may have performance implications (see below). | ||
| >Sử dụng `Function.prototype.bind` trong hàm render tạo ra một function mới mỗi lần component renders, điều đó có thể liên quan tới hiệu xuất (Xem bên dưới). |
There was a problem hiding this comment.
It should be "hiệu suất".
content/docs/faq-functions.md
Outdated
|
|
||
| See [this visualization](http://demo.nimius.net/debounce_throttle/) for a comparison of `throttle` and `debounce` functions. | ||
| Xem [ví dụ này](http://demo.nimius.net/debounce_throttle/) để so sánh giữa các hàm `throttle` và `debounce`. |
There was a problem hiding this comment.
visualization mình có thể translate là "đặc tả" hay gì đó được hơn là "ví dụ"
There was a problem hiding this comment.
Mình nghĩ dịch thành Xem mô phỏng này có vẻ hợp lý hơn
* 'master' of https://github.com/reactjs/vi.reactjs.org: resolve conflict Some fixes to the Accessibility guide (#2047)
|
@ltmylinh Pls, Review it ! |
cuongtran8
reviewed
Jun 5, 2019
cuongtran8
reviewed
Jun 5, 2019
cuongtran8
reviewed
Jun 5, 2019
cuongtran8
reviewed
Jun 5, 2019
cuongtran8
reviewed
Jun 5, 2019
cuongtran8
reviewed
Jun 5, 2019
|
Thanks @cuongtran8, i fixed and PR, review it. |
cuongtran8
requested changes
Jun 5, 2019
* 'master' of https://github.com/reactjs/vi.reactjs.org: Remove outdated link to React FAQ website (#2043) Use imperative tone for suggested commit message (#2050)
cuongtran8
approved these changes
Jun 13, 2019
|
@ltmylinh Merge it, tks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.