Skip to content

Sync with reactjs.org @ e1abbdec #356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 36 commits into from
Closed

Conversation

reactjs-translation-bot
Copy link
Contributor

@reactjs-translation-bot reactjs-translation-bot commented Jul 10, 2019

This PR was automatically generated.

Merge changes from reactjs.org at e1abbde

The following files have conflicts and may need new translations:

Please fix the conflicts by pushing new commits to this pull request, either by editing the files directly on GitHub or by checking out this branch.

DO NOT SQUASH MERGE THIS PULL REQUEST!

Doing so will "erase" the commits from master and cause them to show up as conflicts the next time we merge.

EmmaB and others added 24 commits June 23, 2019 14:07
Please refer to https://justsimply.dev for the thinking behind these proposed changes.
An example for useEffect omitted the actual invocation of the function in question.
* Fixed minor code-splitting.md typo

* Update code-splitting.md


Co-authored-by: Alexey Pyltsyn <lex61rus@gmail.com>
* Replaced broken discuss.reactjs.org link

On the how-to-contribute page, there is a broken link under the https://reactjs.org/docs/how-to-contribute.html#how-to-get-in-touch section. As outlined in reactjs/react.dev#2080 `discuss.reactjs.org` isn't reachable.

I edited the text to display `Discussion Forums` which links to https://reactjs.org/community/support.html#popular-discussion-forums (as I was unable to find an official reactjs discussion forum).

* fixed text case

changed `Discussion Forums` to `Discussion forums`
Add JaipurJS - JavaScript meetup in Jaipur, Rajasthan, India
A great video/editor tutorial consisting of 48 hands-on lessons.
* Update Production Optimization docs to use terser

* Update Optimizing Performance.md

* Fix typo

Co-Authored-By: Alexey Pyltsyn <lex61rus@gmail.com>
* Update hooks-faq.md

I tripped up slightly while reading this example for using the callback form of a state setter inside an effect. I've added a few lines that might help a hook newbie grok the differences between the examples.

* Update hooks-faq.md

* Update hooks-faq.md
changed 'any React apps' to 'any React app'
* React Native added support for hooks in 0.59

React Native 0.59 and above already support React Hooks, this line is no longer necessary, causes confusion for some people that it is not working right now. We can also mention React Native version if needed.

* update with react native mention of hooks support

* Update content/docs/hooks-faq.md

suggested changes

Co-Authored-By: Alexey Pyltsyn <lex61rus@gmail.com>
@netlify
Copy link

netlify bot commented Jul 10, 2019

Deploy preview for ru-reactjs ready!

Built with commit 988daaf

https://deploy-preview-356--ru-reactjs.netlify.com

@gcor
Copy link
Collaborator

gcor commented Jul 23, 2019

Нужна помощь с этим мерджем? Вроде бы уже часть сделана.

@gcor gcor mentioned this pull request Jul 27, 2019
@gcor gcor closed this Jul 27, 2019
@lex111
Copy link
Member

lex111 commented Jul 31, 2019

@gcor привет, выпал из интернет-пространства, как я понимаю, всё уже решено?

@gcor
Copy link
Collaborator

gcor commented Aug 1, 2019

@lex111 ага)

@ntishkevich ntishkevich deleted the sync-e1abbdec branch August 6, 2019 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.