Fix visible background over border radius in search dropdown #90
+6
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview ready! Built with commit 06a8b8e |
bvaughn
requested changes
Oct 9, 2017
|
@bvaughn , yep i'll be happy to fix any issues. Just visited the autogenerated preview of the PR on my phone (https://deploy-preview-90--reactjs.netlify.com/) but at first glance couldn't see the horizontal overflow : S Can you attach a screenshot or give me a few more details? |
bvaughn
approved these changes
Oct 9, 2017
BetterZxx
pushed a commit
to BetterZxx/react.dev
that referenced
this pull request
Mar 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the algolia search results have a weird and subtle but eye-twitch-inducing artifact, where you can see the white background on the top round borders of the dropdown.
It looks like this:
This PR moves the background from the top container to each individual row that must be white in order to achieve the same effect.
It would look like this: