Skip to content

Fixed multiple duplicate codepen embed scripts issue #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ishankbahl
Copy link
Contributor

Fix issue #62 by removing the two duplicate CodePen embed scripts on the Thinking in React doc page.

@reactjs-bot
Copy link

Deploy preview ready!

Built with commit bb70044

https://deploy-preview-65--reactjs.netlify.com

@facebook-github-bot
Copy link
Collaborator

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Collaborator

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Copy link
Contributor

@bvaughn bvaughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes to content/docs/thinking-in-react.md look good. Please revert the modified yarn.lock file though 😄

@bvaughn
Copy link
Contributor

bvaughn commented Oct 8, 2017

Oh, whoops! Looks like a PR (#63) was already opened before this one to fix this. I'll go ahead and merge the earlier one. Sorry! 😄

@bvaughn bvaughn closed this Oct 8, 2017
@ishankbahl ishankbahl deleted the remove-two-duplicate-codepen-embed-scripts branch October 8, 2017 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants