Skip to content

Update event label and value name #6421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

kmiddleton14
Copy link
Contributor

  • Update category name to be more specific for the feedback button
  • Update value name to event_value

Verify it's being populated in GA
Screenshot 2023-11-08 at 11 28 04 AM
Screenshot 2023-11-06 at 6 11 24 PM

Copy link

github-actions bot commented Nov 8, 2023

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Three Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/404 77.34 KB (🟡 +11 B) 181.09 KB
/500 77.34 KB (🟡 +11 B) 181.08 KB
/[[...markdownPath]] 78.93 KB (🟡 +11 B) 182.68 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@kmiddleton14 kmiddleton14 marked this pull request as ready for review November 8, 2023 16:39
@kmiddleton14 kmiddleton14 merged commit eeb0979 into reactjs:main Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants