Fix feedback gtag value #6415
Merged
Fix feedback gtag value #6415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmiddleton14
requested review from
davidmccabe,
lunaleaps and
mattcarrollcode
Size changes📦 Next.js Bundle Analysis for react-devThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
brianjo
approved these changes
Nov 7, 2023
lunaleaps
reviewed
Nov 7, 2023
| // Fragile. Don't change unless you've tested the network payload | ||
| // and verified that the right events actually show up in GA. | ||
| // @ts-ignore | ||
| gtag('event', 'feedback', { | ||
| event_category: 'button', | ||
| event_label: window.location.pathname, | ||
| value: isPositive ? 1 : 0, |
There was a problem hiding this comment.
@kmiddleton14 I might be missing something obvious but what exactly fixed this? Isn't this change the same?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feedback event wasn't displaying the parameter value in google analytics. By checking the boolean before passing to gtag fixes it. I've verified we're now seeing param values of the feedback event 'button' in google analytics