add shorthand for specifying pixel values in style props to docs #55
Conversation
|
Deploy preview ready! Built with commit f3aea25 |
| return <div style={divStyle}>Hello World!</div>; | ||
| } | ||
| ``` | ||
|
|
There was a problem hiding this comment.
I think the section about which props are unitless is also worth adding just to avoid potential confusion that all numeric style props are stringified like this.
There was a problem hiding this comment.
Should it be updated to reflect the latest changes in this file(20 of them are not on the list)?
There was a problem hiding this comment.
Sure, or maybe just mention the type of props that aren't converted and list a few examples?
There was a problem hiding this comment.
Alright, I left it as is and include a link to the file.
|
Thanks! |
| </div> | ||
| ``` | ||
|
|
||
| Not all style properties are converted to pixel strings though. Certain ones remain unitless (eg `zoom`, `order`, `flex`). A complete list of unitless properties can be seen [here](https://github.com/facebook/react/blob/4131af3e4bf52f3a003537ec95a1655147c81270/src/renderers/dom/shared/CSSProperty.js#L15-L59). |
There was a problem hiding this comment.
This actually got me curious -- while the first and second values of flex are unitless, the third is not. Luckily, it's not possible to provide more than one value other than as a string...
* Translate: Context * Translate: Context first review
Fix #27