Fixes #44 : Update CodeEditor to display the complete content #51
Conversation
|
Deploy preview ready! Built with commit 521f334 |
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
There was a problem hiding this comment.
Thanks for working on this issue! It's definitely an improvement to be able to scroll to the bottom of the code snippet 😅 although there's still some funky margin/padding going on that would be nice to clear up:
This change essentially double-pads the bottom (at least it gives that visual appearance).
src/css/reset.css
Outdated
|
|
||
| pre::scrollbar { | ||
| display: none; | ||
| } |
There was a problem hiding this comment.
We shouldn't disable the scrollbar display like this (although I agree with you that browser scrollbars are generally unattractive). Users depend on scrollbars to indicate that there's content below the fold. Hiding the scrollbar can be a confusing user experience. Also, unless users have a trackpad or a mouse-wheel, they would be unable to scroll the content in this case.
There was a problem hiding this comment.
Yes, correct :) Reverting this change and updating the PR.
akshatnitd
force-pushed
the
scroll-bar
branch
2 times, most recently
from
7e4f340 to
404c34e
Compare
|
@bvaughn Made the requested changes :) |
|
@bvaughn Thanks for merging :) This was my first PR to the org 😄 Many more to come! 🎆 |
|
We're excited to hear that! |
* translation first version * Update content/docs/conditional-rendering.md fix url Co-Authored-By: cstpk <costasnataly@gmail.com> * Apply suggestions from code review fix typos, accents and links Co-Authored-By: cstpk <costasnataly@gmail.com> * Update content/docs/conditional-rendering.md Co-Authored-By: cstpk <costasnataly@gmail.com> * Update content/docs/conditional-rendering.md Co-Authored-By: cstpk <costasnataly@gmail.com> * Update content/docs/conditional-rendering.md Co-Authored-By: cstpk <costasnataly@gmail.com> * Update content/docs/conditional-rendering.md Co-Authored-By: cstpk <costasnataly@gmail.com> * Update content/docs/conditional-rendering.md Co-Authored-By: cstpk <costasnataly@gmail.com> * removed extra new line * Update content/docs/conditional-rendering.md Co-Authored-By: cstpk <costasnataly@gmail.com> * Update content/docs/conditional-rendering.md Co-Authored-By: cstpk <costasnataly@gmail.com> * Update content/docs/conditional-rendering.md Co-Authored-By: cstpk <costasnataly@gmail.com> * Update content/docs/conditional-rendering.md Co-Authored-By: cstpk <costasnataly@gmail.com> * Update content/docs/conditional-rendering.md Co-Authored-By: cstpk <costasnataly@gmail.com>
The code at the bottom of the CodeEditor in the examples was hidden, due to overflow : 'hidden' to the parent element. Made changes to show complete code. Also, hid the scroll-bar for better UI.