Docs for Error Boundaries #31
Conversation
|
Deploy preview ready! Built with commit 03dae5b |
content/docs/error-boundaries.md
Outdated
| showButton(); | ||
| } catch (error) { | ||
| // ... | ||
| } |
There was a problem hiding this comment.
nit: You can get rid of this indentation
content/docs/error-boundaries.md
Outdated
| However, React components are declarative and specify *what* should be rendered: | ||
|
|
||
| ```js | ||
| <Button /> |
There was a problem hiding this comment.
nit: Ditto about indentation.
content/docs/error-boundaries.md
Outdated
|
|
||
| React 16 prints all errors that occurred during rendering to the console in development, even if the application accidentally swallows them. In addition to the error message and the JavaScript stack, it also provides component stack traces. Now you can see where exactly in the component tree the failure has happened: | ||
|
|
||
| <img src="../images/docs/error-boundaries-error-log.png" style="max-width:100%" alt="Error caught by Error Boundary component"> |
There was a problem hiding this comment.
It might be nice to share these images between the blog post and the docs page, since they're the same. Maybe git mv the images into images/docs and then update the blog markdown to reference them there?
content/docs/error-boundaries.md
Outdated
|
|
||
| Note that **error boundaries only catch errors in the components below them in the tree**. An error boundary can’t catch an error within itself. If an error boundary fails trying to render the error message, the error will propagate to the closest error boundary above it. This, too, is similar to how catch {} block works in JavaScript. | ||
|
|
||
| #### componentDidCatch Parameters |
There was a problem hiding this comment.
nit: I think this should be an <h3> (eg ###) rather than <h4>
krizzu
force-pushed
the
docs/Error-Boundaries
branch
from
06b220b to
96e65ae
Compare
|
Thanks @bvaughn |
|
Oooh, one more thing! We require contributors to sign our Contributor License Agreement, and I don't think we have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. (Sorry for the awkwardness here. I'm still getting the new repo setup. Normally this comment is automated.) |
|
No worries, I've already signed it :) |
|
Great 😄 Thanks for confirming. Just need to fix the tiny indentation issue and this looks good to go! |
krizzu
force-pushed
the
docs/Error-Boundaries
branch
from
96e65ae to
03dae5b
Compare
|
@bvaughn |
* translate React API Reference * Update content/docs/reference-react.md Co-Authored-By: renato-bohler <renato.bohler@gmail.com> * Update content/docs/reference-react.md Co-Authored-By: renato-bohler <renato.bohler@gmail.com> * Update content/docs/reference-react.md Co-Authored-By: renato-bohler <renato.bohler@gmail.com> * Update content/docs/reference-react.md Co-Authored-By: renato-bohler <renato.bohler@gmail.com> * Update content/docs/reference-react.md Co-Authored-By: renato-bohler <renato.bohler@gmail.com> * Update content/docs/reference-react.md Co-Authored-By: renato-bohler <renato.bohler@gmail.com> * Update content/docs/reference-react.md Co-Authored-By: renato-bohler <renato.bohler@gmail.com> * Update content/docs/reference-react.md Co-Authored-By: renato-bohler <renato.bohler@gmail.com> * Update content/docs/reference-react.md Co-Authored-By: renato-bohler <renato.bohler@gmail.com> * Update content/docs/reference-react.md Co-Authored-By: renato-bohler <renato.bohler@gmail.com> * Update content/docs/reference-react.md Co-Authored-By: renato-bohler <renato.bohler@gmail.com> * Update content/docs/reference-react.md Co-Authored-By: renato-bohler <renato.bohler@gmail.com> * Update content/docs/reference-react.md Co-Authored-By: renato-bohler <renato.bohler@gmail.com> * Update content/docs/reference-react.md Co-Authored-By: renato-bohler <renato.bohler@gmail.com> * Update content/docs/reference-react.md Co-Authored-By: renato-bohler <renato.bohler@gmail.com> * Update content/docs/reference-react.md Co-Authored-By: renato-bohler <renato.bohler@gmail.com> * Update content/docs/reference-react.md Co-Authored-By: renato-bohler <renato.bohler@gmail.com> * Update content/docs/reference-react.md Co-Authored-By: renato-bohler <renato.bohler@gmail.com> * Update content/docs/reference-react.md Co-Authored-By: renato-bohler <renato.bohler@gmail.com> * Update content/docs/reference-react.md Co-Authored-By: renato-bohler <renato.bohler@gmail.com> * Update content/docs/reference-react.md Co-Authored-By: renato-bohler <renato.bohler@gmail.com> * Update content/docs/reference-react.md Co-Authored-By: renato-bohler <renato.bohler@gmail.com> * Update content/docs/reference-react.md * Update content/docs/reference-react.md
Hey,
Moved this PR here, as said :)