Skip to content

Fix setState example code #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 16, 2017
Merged

Fix setState example code #290

merged 1 commit into from
Nov 16, 2017

Conversation

NilSet
Copy link
Contributor

@NilSet NilSet commented Nov 16, 2017

Seems to have been a mix of the two examples the section was covering.

Seems to have been a mix of the two examples the section was covering.
@facebook-github-bot
Copy link
Collaborator

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@reactjs-bot
Copy link

Deploy preview ready!

Built with commit 1303a3d

https://deploy-preview-290--reactjs.netlify.com

@facebook-github-bot
Copy link
Collaborator

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Copy link
Contributor

@bvaughn bvaughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bvaughn bvaughn merged commit 825bae0 into reactjs:master Nov 16, 2017
jhonmike pushed a commit to jhonmike/reactjs.org that referenced this pull request Jul 1, 2020
BetterZxx pushed a commit to BetterZxx/react.dev that referenced this pull request Mar 21, 2023
…tjs#290)

按照原文(英文)的意思,只有将 `undefined` 的 value 传递给 Provider 时,消费 context 的组件的 defaultValue 才不会生效。
而翻译中没有提到 Provider 的 value,不够清楚。
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants