Clean update of Community Section #273
Conversation
|
Deploy preview ready! Built with commit 0dcefd4 |
| --- | ||
|
|
||
| * **[Apollo](http://dev.apollodata.com/react/):** Easy to set up and use GraphQL client. | ||
| * **[Axios](https://github.com/mzabriskie/axios):** Promise based HTTP client for the browser and node.js. |
There was a problem hiding this comment.
I'm surprised that URLs like these actually get resolved to GitHub links, but they seem to 😮
content/community/videos.md
Outdated
| <th></th><td></td> | ||
| </tr> | ||
| </table> | ||
| - [Introduction to React](https://www.youtube.com/watch?v=XxVg_s8xAms&feature=youtu.be) (2013 - 1h20m) - Tom Occhino and Jordan Walke introduce React at Facebook Seattle. |
There was a problem hiding this comment.
I think the embedded videos were kind of nice. I'm curious why you removed them?
There was a problem hiding this comment.
My only reasoning was to keep the cohesiveness between pages / sections. Most other sections had a bullet list layout for the links, so I thought I would keep it the same. I'm not married to the idea and certainly don't mind reverting to the embedded videos. Your call @bvaughn !
There was a problem hiding this comment.
I don't feel strongly, but I think the embedded videos might be a nice touch.
|
Ok, added the embedded videos back in and added new embeds for the conference playlists. Is that what you had in mind @bvaughn ? |
content/community/videos.md
Outdated
|
|
||
| ### Introducing React Native | ||
|
|
||
| [Tom Occhino](https://twitter.com/tomocchino) reviews the past and present of React in 2015, and teases where it's going next. |
There was a problem hiding this comment.
I'm a little confused by the change of the order of videos. It makes it a bit hard to tell for sure, but it looks like some videos were lost. Like this one. It's not on the page anymore.
There was a problem hiding this comment.
I tried to arrange the videos chronologically from newest to oldest. A couple of the videos from the original page are now included as part of the React.js Conf playlists. For example, Tom's video above is the first video in the React.js Conf 2015 playlist. I'll scan through the list and make sure no videos were completely removed. Does that make sense? Should I add a sentence about the ordering and playlist at the top of the videos section?
There was a problem hiding this comment.
I see that I also removed the "React and Flux: Building Applications with a Unidirectional Data Flow" video because the video it linked to was in Russian (check the embed on the current page). I found the English version of the video and will add it back in in the recommit 😁
There was a problem hiding this comment.
The ordering is probably fine. It just confused me a bit when trying to verify that no videos were dropped. I don't have a lot of time to review PRs at the moment so I just kind of want to glance through and make sure things don't regress 😄 I don't think you need to add a sentence about the wording or anything. Just make sure we don't lose a video.
There was a problem hiding this comment.
I believe the latest commit addressed your requested changes. I went back through to verify any removed videos were part of the React Conf playlists. I changed the duplicate embedded links to point to the appropriate video. I also added a title to each video to more closely match the current videos section. I'm not sure why I took them out and I believe it makes it a bit easier to read through 😄 .
content/community/videos.md
Outdated
| <iframe title="Mountain West JavaScript 2014 - Be Predictable, Not Correct. by Pete Hunt" width="650" height="366" src="https://www.youtube-nocookie.com/embed/h3KksH8gfcQ" frameborder="0" allowfullscreen></iframe> | ||
|
|
||
| ### Rethinking Best Practices | ||
| How Facebook abandoned the traditional MVC paradigm in favor of a more functional application architecture - (2014 - 0h44m). | ||
| <iframe title="Hacker Way: Rethinking Web App Development at Facebook" width="650" height="366" src="https://www.youtube-nocookie.com/embed/nYkdrAPrdcw" frameborder="0" allowfullscreen></iframe> |
There was a problem hiding this comment.
This same video (www.youtube-nocookie.com/embed/nYkdrAPrdcw) appears to be duplicated 3x on the new page.
There was a problem hiding this comment.
Yikes! I must have copied the same iframe to multiple places when I was replacing the links with the previous iframes. I'll change those to link to the correct video and recommit! 😄
|
Hey @bvaughn I just wanted to say thanks for all your patience and input on this PR. I know your time is limited and this probably required a little more attention that normal, but I learned a ton and look forward to contributing more! 😄 |
|
What's the plan for the Wiki now? Shall we close it? Point people to the website? |
|
You're welcome, @mateoholman. We look forward to your contributions. 😄 Yeah @gaearon! We should edit the pages to reference the website instead. |
docs(en): merge reactjs.org into zh-hans @ a091165
@bvaughn Here is the cleaned-up PR for the updated Community Section! 😁