Make error boundary doc more in style with the post #213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaearon
commented
Oct 26, 2017
| @@ -136,37 +137,42 @@ However, React components are declarative and specify *what* should be rendered: | |||
|
|
|||
| Error boundaries preserve the declarative nature of React, and behave as you would expect. For example, even if an error occurs in a `componentDidUpdate` hook caused by a `setState` somewhere deep in the tree, it will still correctly propagate to the closest error boundary. | |||
|
|
|||
| However, an event handler inside of a React component could leverage `try` / `catch` to deal with errors that occur during event handling. | |||
There was a problem hiding this comment.
This sounded a bit like an ad for try/catch :-)
|
Deploy preview ready! Built with commit 09dbffb |
|
Deploy preview ready! Built with commit 0589024 |
|
Deploy preview ready! Built with commit e4c9d19 |
|
I’ll just get it in. I think it’s better this way. |
jhonmike
pushed a commit
to jhonmike/reactjs.org
that referenced
this pull request
Jul 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I find the clarifications different in style from the original post. Tried to make them look more in line with it.