Skip to content

inputs array > dependencies array #1957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 9, 2019
Merged

inputs array > dependencies array #1957

merged 2 commits into from
May 9, 2019

Conversation

kentcdodds
Copy link
Contributor

I think initially this was referred to as the "inputs array" in the docs, then it was changed to the "dependencies array" everywhere except it looks like a few were missed.

Kent C. Dodds added 2 commits April 30, 2019 12:01
I think initially this was referred to as the "inputs array" in the docs, then it was changed to the "dependencies array" everywhere except it looks like a few were missed.
I think initially this was referred to as the "inputs array" in the docs, then it was changed to the "dependencies array" everywhere except it looks like a few were missed.
@kentcdodds
Copy link
Contributor Author

I almost tweeted this 😬

image

Then decided to look around and I think it's dependencies :) Better to keep things consistent and avoid confusion!

@reactjs-bot
Copy link

Deploy preview for reactjs ready!

Built with commit 2851956

https://deploy-preview-1957--reactjs.netlify.com

@kentcdodds
Copy link
Contributor Author

Ping. This should be a quick merge.

@alexkrolick alexkrolick merged commit b91049c into reactjs:master May 9, 2019
@kentcdodds kentcdodds deleted the patch-2 branch May 9, 2019 17:52
@kentcdodds
Copy link
Contributor Author

Oh! @alexkrolick! Fancy meeting you here. I had no idea you were a maintainer of reactjs.org too. Very cool 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants